Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: base: Remove non-functional theme option #1118

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

michaelwood
Copy link
Member

This appears to access an out of scope variable and is actually no longer needed.

Fixes: #1117

This appears to access an out of scope variable and is actually no
longer needed.

Fixes: #1117
@michaelwood
Copy link
Member Author

@michaelwood michaelwood requested a review from R2ZER0 October 18, 2024 15:38
@michaelwood
Copy link
Member Author

This will fix the test that is currently failing but only once deployed as it is referencing live

Copy link
Contributor

@R2ZER0 R2ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@michaelwood michaelwood merged commit e272a1d into live Oct 23, 2024
4 of 6 checks passed
@michaelwood michaelwood deleted the mw/fix_helpsite_error branch October 23, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helpsite "Uncaught ReferenceError: SphinxRtdTheme is not defined"
2 participants