Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data file submission guidance update #385

Merged
merged 11 commits into from
Jul 17, 2024
Merged

Conversation

ksmith360G
Copy link
Contributor

Hi Matt,
I've created a branch to update some guidance about our data file submission process. It's all ready except for the screenshot that I can't get to work. The screenshot is here assets/DFS Screenshot 2024-06-07 New button names.png
It is in the second bullet point of this section https://standard.threesixtygiving.org/en/ks_dfs_guidance_update/guidance/submit-data/#submit-the-link-to-your-file

Can you please take a look at this and let me know why it hasn't worked and help to get it sorted out?
Thanks so much!
Kerry

Add one screenshot to show where the DFS section is (Submit you data), and simplify instructions with bullet points for each submission type/option
To see the location of the Submit your file part of the DQT, and the new button names on the page
Second edit and attempting adding a screenshot
change DQT link
removed a comma
Last change to full stops in bullet points
@ksmith360G ksmith360G requested a review from mrshll1001 July 12, 2024 13:20
@mrshll1001
Copy link
Contributor

I've changed the name of the file to remove the spaces and I think that's fixed it in the latest build. @ksmith360G , would you be able to confirm this is what you want to see?

If so, I think we've just learned that readthedocs doesn't like spaces in file names. One to add to my notebook of "random things that readthedocs does" I think!

If all is well I'm happy to accept the PR and merge in as everything else is in order :-)

@ksmith360G
Copy link
Contributor Author

Thanks so much Matt - I really appreciate it. I'll also make a note of the spaces in the filenames.
I'm happy for you to go ahead, thank you!

@mrshll1001 mrshll1001 merged commit d51c718 into main Jul 17, 2024
2 checks passed
@mrshll1001 mrshll1001 deleted the KS_DFS_guidance_update branch July 17, 2024 13:18
@ksmith360G
Copy link
Contributor Author

Wonderful - thanks so much Matt, it looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants