Skip to content

Feature: add Tibia Forums Section details (v3/forum/section/{name}) #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

simivar
Copy link

@simivar simivar commented Jun 6, 2023

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #215 (0e72293) into v3 (4dd6e10) will decrease coverage by 0.79%.
The diff coverage is 60.41%.

@@            Coverage Diff             @@
##               v3     #215      +/-   ##
==========================================
- Coverage   84.08%   83.30%   -0.79%     
==========================================
  Files          22       23       +1     
  Lines        2921     3012      +91     
==========================================
+ Hits         2456     2509      +53     
- Misses        405      441      +36     
- Partials       60       62       +2     

@tobiasehlert
Copy link
Member

Hi @simivar,

Thanks for your PR first of all!

I will release v4 any day, so it would be great if you could open a PR towards the main branch instead of v3, so that we get the new functionality with the new release.

Kind regards,
Tobias

@simivar
Copy link
Author

simivar commented Jun 12, 2023

Hey @tobiasehlert,

sure, no problem! Can we get it merged to v3 as well as it's not a breaking change? I will make one more adjustment to the URL so it's more in line with what we have for other URLs and naming on Tibia.com but otherwise it's ready to be merged.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@simivar simivar changed the title Feature: add Tibia Forums overview endpoint (v3/forums/{name}) Feature: add Tibia Forums overview endpoint (v3/forum/section/{name}) Jun 12, 2023
@simivar simivar changed the title Feature: add Tibia Forums overview endpoint (v3/forum/section/{name}) Feature: add Tibia Forums Section details (v3/forum/section/{name}) Jun 12, 2023
@simivar
Copy link
Author

simivar commented Jun 12, 2023

Hey @tobiasehlert,

MR should be ready to be merged to v3. I'll prepare it for main (v4) in upcoming days. If you can and would like to merge it to both that would be amazing!

@tobiasehlert
Copy link
Member

Thanks for your contribution @simivar, but since V3 is deprecated I'll not include this PR for now.
I'll look into #220 since it's practically identical to this, but for V4 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants