Skip to content

Commit

Permalink
fix: sidebar
Browse files Browse the repository at this point in the history
  • Loading branch information
nachozullo committed Apr 23, 2024
1 parent cd3b4a3 commit 039ef73
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 6 deletions.
1 change: 1 addition & 0 deletions .yarn/versions/35d7933f.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
releases:
"@nimbus-ds/chip": patch
"@nimbus-ds/components": patch
"@nimbus-ds/sidebar": patch
"@nimbus-ds/styles": patch

declined:
Expand Down
2 changes: 1 addition & 1 deletion packages/core/styles/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nimbus-ds/styles",
"version": "9.11.5-rc.2",
"version": "9.11.5-rc.3",
"license": "MIT",
"main": "dist/index.js",
"files": [
Expand Down
1 change: 1 addition & 0 deletions packages/react/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Nimbus is an open-source Design System created by Tiendanube / Nuvesmhop’s tea
### 💡 Others

- Trigger `onClick` only when close icon is pressed on `Chip` component. ([#110](https://github.com/TiendaNube/nimbus-design-system/pull/240) by [@nachozullo](https://github.com/nachozullo))
- Added `lockScroll` to prevent scroll outside of the body of `Sidebar` component. ([#110](https://github.com/TiendaNube/nimbus-design-system/pull/240) by [@nachozullo](https://github.com/nachozullo))

## 2024-03-18 `5.5.3`

Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nimbus-ds/components",
"version": "5.5.4-rc.2",
"version": "5.5.4-rc.3",
"license": "MIT",
"main": "dist/index.js",
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/atomic/Chip/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nimbus-ds/chip",
"version": "2.3.3-rc.2",
"version": "2.3.3-rc.3",
"license": "MIT",
"main": "dist/index.js",
"files": [
Expand Down
8 changes: 7 additions & 1 deletion packages/react/src/composite/Sidebar/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@

The Sidebar component is a large floating container that goes into the page from the corners. It allows us to present actions, forms or sections with a lot of information about the context of the page.

## 2024-04-15gs `3.3.0`
## 2024-04-22 `3.3.1`

#### 🐛 Bug fixes

- Added `lockScroll` to prevent scroll outside of the body of `Sidebar` component. ([#110](https://github.com/TiendaNube/nimbus-design-system/pull/240) by [@nachozullo](https://github.com/nachozullo))

## 2024-04-15 `3.3.0`

#### 🐛 Bug fixes

Expand Down
5 changes: 3 additions & 2 deletions packages/react/src/composite/Sidebar/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nimbus-ds/sidebar",
"version": "3.3.0",
"version": "3.3.1-rc.1",
"license": "MIT",
"main": "dist/index.js",
"files": [
Expand Down Expand Up @@ -35,5 +35,6 @@
"@nimbus-ds/button": "workspace:^",
"@nimbus-ds/text": "workspace:^",
"@nimbus-ds/webpack": "workspace:^"
}
},
"stableVersion": "3.3.0"
}
1 change: 1 addition & 0 deletions packages/react/src/composite/Sidebar/src/Sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ const Sidebar: React.FC<SidebarProps> & SidebarComponents = ({
<FloatingOverlay
className={sidebar.classnames.overlay}
data-testid="overlay-sidebar-button"
lockScroll={!needRemoveScroll}
>
<FloatingFocusManager context={context}>
<div
Expand Down

0 comments on commit 039ef73

Please sign in to comment.