Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Tabs.Item new prop labelContent [ECNIM-901] #218

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

juanchigallego
Copy link
Contributor

@juanchigallego juanchigallego commented Jan 18, 2024

Type

  • Bugfix πŸ›
  • New feature 🌈
  • Change request πŸ€“
  • Documentation πŸ“š
  • Tech debt πŸ‘©β€πŸ’»

Changes proposed βœ”οΈ

@nimbus-ds/[email protected]

πŸŽ‰ New features

  • Add labelContent prop to Tabs.Item subcomponent to include a child node on the tab button. (#218 by @juanchigallego)

@nimbus-ds/[email protected]

πŸŽ‰ New features

  • Add labelContent prop to Tabs.Item subcomponent to include a child node on the tab button. (#218 by @juanchigallego)

@nimbus-ds/[email protected]

Copy link

Getting started

Please make sure you read our documentation on how to write code for components, stories and styles.

  • Provide a list of changes
  • Include images to help better visualize your work
  • If your PR closes an issue, please link it
  • Add reviewers
  • Add a label to help better understand what your changes are related to

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (30822cc) 99.52% compared to head (60b9cfb) 99.52%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files         288      288           
  Lines        1912     1912           
  Branches      278      278           
=======================================
  Hits         1903     1903           
  Misses          8        8           
  Partials        1        1           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@juanchigallego juanchigallego merged commit 11b2067 into master Jan 18, 2024
3 of 4 checks passed
@juanchigallego juanchigallego deleted the ecnim-901 branch January 18, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants