Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar #233

Merged
merged 8 commits into from
Apr 17, 2024
Merged

Fix sidebar #233

merged 8 commits into from
Apr 17, 2024

Conversation

juanchigallego
Copy link
Contributor

@juanchigallego juanchigallego commented Mar 18, 2024

Type

  • Bugfix πŸ›
  • [] New feature 🌈
  • Change request πŸ€“
  • Documentation πŸ“š
  • Tech debt πŸ‘©β€πŸ’»

Changes proposed βœ”οΈ

@nimbus-ds/[email protected]

πŸ› Bug fixes

  • Added RemoveScroll component from react-remove-scroll library to prevent scroll resetting on the body of the Sidebar component. (#233 by @juanchigallego)
  • Fixed type bug on expected icon and text color values on Toast component. (#233 by @juanchigallego)

πŸ“š 3rd party library updates

@nimbus-ds/[email protected]

πŸ› Bug fixes

@nimbus-ds/[email protected]

πŸ› Bug fixes

  • Added RemoveScroll component from react-remove-scroll library to prevent scroll resetting on the body of the Sidebar component. (#233 by @juanchigallego)

πŸ“š 3rd party library updates

Copy link

github-actions bot commented Mar 18, 2024

Getting started

Please make sure you read our documentation on how to write code for components, stories and styles.

  • Provide a list of changes
  • Include images to help better visualize your work
  • If your PR closes an issue, please link it
  • Add reviewers
  • Add a label to help better understand what your changes are related to

nachozullo
nachozullo previously approved these changes Mar 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.44%. Comparing base (6da7a8b) to head (434283b).
Report is 1 commits behind head on master.

Files Patch % Lines
...ckages/react/src/composite/Sidebar/src/Sidebar.tsx 60.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   99.54%   99.44%   -0.10%     
==========================================
  Files         298      298              
  Lines        1970     1976       +6     
  Branches      293      297       +4     
==========================================
+ Hits         1961     1965       +4     
- Misses          8        9       +1     
- Partials        1        2       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@nachozullo nachozullo merged commit 892c96f into master Apr 17, 2024
3 of 4 checks passed
@nachozullo nachozullo mentioned this pull request Apr 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants