Release 18/12/2024 #262
Merged
Release 18/12/2024 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(modal): make `onDismiss` optional and conditionally render close button * feat: add change * feat: fix change * feat: add change log * feat: add change log * feat: fix change log * feat: fix change log * feat: fix change logs * fix: versions yml * feat: fix test --------- Co-authored-by: dommirr <[email protected]> Co-authored-by: Ignacio Zullo Salvucci <[email protected]> Co-authored-by: Harry Barzola <[email protected]>
* fix: tabs align center when is full * chore: include patch to components * docs: add changelog
Getting startedPlease make sure you read our documentation on how to write code for components, stories and styles.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 298 298
Lines 1977 1979 +2
Branches 290 292 +2
=======================================
+ Hits 1962 1964 +2
Misses 13 13
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
nachozullo
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Changes proposed ✔️
@nimbus-ds/[email protected]🐛 Bug fixes
onDismissproperty optional forModalcomponent. IfonDismissis not provided, the modal can no longer be closed by clicking outside or pressing the close button. Removed the close button (X) fromModalcomponent whenonDismissis not provided. (#246 by @dommirr)@nimbus-ds/[email protected]🐛 Bug fixes
onDismissproperty optional forModalcomponent. IfonDismissis not provided, the modal can no longer be closed by clicking outside or pressing the close buttonModalcomponent whenonDismissis not provided. (#246 by @dommirr)@nimbus-ds/[email protected]🐛 Bug fixes
@nimbus-ds/[email protected]🐛 Bug fixes