Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 18/12/2024 #263

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Release 18/12/2024 #263

merged 3 commits into from
Dec 18, 2024

Conversation

harrytiendanube
Copy link
Contributor

Type

  • Bugfix 🐛

Changes proposed ✔️

@nimbus-ds/[email protected]

🐛 Bug fixes

  • Made onDismiss property optional for Modal component. If onDismiss is not provided, the modal can no longer be closed by clicking outside or pressing the close button. Removed the close button (X) from Modal component when onDismiss is not provided. (#246 by @dommirr)
  • We detected that the content of the Tabs, when set to full, was not centered but aligned to the left. (#261 by @harrytiendanube)

@nimbus-ds/[email protected]

🐛 Bug fixes

  • Made onDismiss property optional for Modal component. If onDismiss is not provided, the modal can no longer be closed by clicking outside or pressing the close button
  • Removed the close button (X) from Modal component when onDismiss is not provided. (#246 by @dommirr)

@nimbus-ds/[email protected]

🐛 Bug fixes

  • We detected that the content of the Tabs, when set to full, was not centered but aligned to the left. (#261 by @harrytiendanube)

@nimbus-ds/[email protected]

🐛 Bug fixes

  • We detected that the content of the Tabs, when set to full, was not centered but aligned to the left. (#261 by @harrytiendanube)

dommirr and others added 3 commits December 18, 2024 15:10
* fix(modal): make `onDismiss` optional and conditionally render close button

* feat: add change

* feat: fix change

* feat: add change log

* feat: add change log

* feat: fix change log

* feat: fix change log

* feat: fix change logs

* fix: versions yml

* feat: fix test

---------

Co-authored-by: dommirr <[email protected]>
Co-authored-by: Ignacio Zullo Salvucci <[email protected]>
Co-authored-by: Harry Barzola <[email protected]>
* fix: tabs align center when is full

* chore: include patch to components

* docs: add changelog
@harrytiendanube harrytiendanube requested a review from a team as a code owner December 18, 2024 21:47
Copy link

Getting started

Please make sure you read our documentation on how to write code for components, stories and styles.

  • Provide a list of changes
  • Include images to help better visualize your work
  • If your PR closes an issue, please link it
  • Add reviewers
  • Add a label to help better understand what your changes are related to

@harrytiendanube harrytiendanube merged commit 2c6415f into master Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants