Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Make invoice success text larger #492

Open
wants to merge 405 commits into
base: main
Choose a base branch
from

Conversation

JaaskelainenL
Copy link

@JaaskelainenL JaaskelainenL commented Sep 11, 2024

The text has been made bigger so it's easier to read. Now the size is 2xl.

Closes #482

Description

Fixes #482

Before submitting the PR, please make sure you do the following

  • [ X] If your PR is related to a previously discussed issue, please link to it here.
  • [ X] Prefix your PR title with feat:, fix:, chore:, or docs:.
  • [X ] This message body should clearly illustrate what problems it solves.
  • [ X] Make sure the commit history is linear, up-to-date with main branch and does not contain any erroneous changes

Formatting and linting

  • [ X] Format code with pnpm format and lint the project with pnpm lint

MikaelSiidorow and others added 30 commits May 19, 2024 12:54
* Add icons to navbar links

* Safer rendering

Co-authored-by: Mikael Siidorow <[email protected]>

---------

Co-authored-by: Mikael Siidorow <[email protected]>
* Add icons to navbar links

* Dark mode

* Add back tw inverts

* Remove unused import

* Some style fixes

* Add hero image animation

* Add gradient to front page
joonatanaatos and others added 25 commits November 21, 2024 12:20
…nts (#584)

* feat: create script for fetching contents for upload collections from prod

* feat: create script for removing excess versions from mongo export

* chore: run import from prod with new scripts

* fix: add fallback to node for generate_seeding_data script
* feat!: update to next 15

* fix: make revalidate duration static

* fix: fix broken newsletter buttons in CMS likely due to react version differences

* chore: run pnpm upgrade for next

* fix: use camelCased attributes to make next not complain

---------

Co-authored-by: Kalle Ahlström <[email protected]>
…#586)

Bumps the patches group with 3 updates in the / directory: [tailwindcss](https://github.com/tailwindlabs/tailwindcss), [@radix-ui/react-dialog](https://github.com/radix-ui/primitives) and [@radix-ui/react-navigation-menu](https://github.com/radix-ui/primitives).


Updates `tailwindcss` from 3.4.16 to 3.4.17
- [Release notes](https://github.com/tailwindlabs/tailwindcss/releases)
- [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/v3.4.17/CHANGELOG.md)
- [Commits](tailwindlabs/tailwindcss@v3.4.16...v3.4.17)

Updates `@radix-ui/react-dialog` from 1.1.3 to 1.1.4
- [Changelog](https://github.com/radix-ui/primitives/blob/main/release-process.md)
- [Commits](https://github.com/radix-ui/primitives/commits)

Updates `@radix-ui/react-navigation-menu` from 1.2.2 to 1.2.3
- [Changelog](https://github.com/radix-ui/primitives/blob/main/release-process.md)
- [Commits](https://github.com/radix-ui/primitives/commits)

---
updated-dependencies:
- dependency-name: tailwindcss
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patches
- dependency-name: "@radix-ui/react-dialog"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patches
- dependency-name: "@radix-ui/react-navigation-menu"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patches
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kalle Ahlström <[email protected]>
Co-authored-by: Mikael Siidorow <[email protected]>
@JaaskelainenL JaaskelainenL force-pushed the larger-invoice-success-text branch from 917ea31 to ae00f6d Compare January 15, 2025 15:14
@@ -20,6 +20,8 @@ import {
import { SaveAction } from "../../lib/api/external/laskugeneraattori/actions";
import { type InvoiceGeneratorFormState } from "../../lib/api/external/laskugeneraattori/index";

import { Toaster, toast } from "sonner";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint warnings should be fixed


useEffect(() => {
if (formState?.success === true) toast.success(t("Sent invoice"));
}, [formState]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint warnings should be fixed

>
{t("Sent invoice")}
</p>
<Toaster richColors />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the idea with the toast library is that the toaster component is always rendered and you can call the toast.success (or similar) from anywhere within the application. This should therefore be added to, for example, src/app/[locale]/layout.tsx so that it works anywhere. Now this only works for this usecase because the it is only rendered in this file and it is also conditionally rendered based on formState.success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show larger success message after sending invoice in invoice generator