-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra argument to Group::add_member
#2093
Conversation
Can you run nightlies against Core |
Testing this branch |
Build passed but two test failures. Regardless this means that this PR fixes the broken build against dev libtiledb |
I agree, @jdblischak. However, I don't understand why these two tests are failing. I merged from the dev branch, so these issues should have been fixed by now. |
I guess you have to re-run the workflow from the beginning after I merged. If this is the case, everything is ok. |
The nightly pipeline checked out b0aaccf (log), so it should have had the latest changes from dev from your merge. I also don't know why the 2 tests continue to fail. But I don't believe they are related to this PR. Thus I think we should merge this PR, and then we can continue to troubleshoot the failing tests if necessary. |
Oops. I didn't realize that you had already restarted it. You are correct that on the first attempt it didn't have the latest changes from dev. FWIW the number of failing tests reduced from 3 to 2 after merging dev. https://github.com/TileDB-Inc/centralized-tiledb-nightlies/actions/runs/11407797939/attempts/1 |
Context: TileDB-Inc/centralized-tiledb-nightlies#24 (comment)
Should fix the related error in TileDB-Inc/centralized-tiledb-nightlies#24
cc @jdblischak
[sc-58033]