Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra argument to Group::add_member #2093

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

kounelisagis
Copy link
Member

@kounelisagis kounelisagis commented Oct 18, 2024

@teo-tsirpanis
Copy link
Member

Can you run nightlies against Core dev?

@jdblischak
Copy link
Contributor

Testing this branch agis/add-new-argument-for-Group--add_member against dev libtiledb in https://github.com/TileDB-Inc/centralized-tiledb-nightlies/actions/runs/11407797939

@jdblischak
Copy link
Contributor

Build passed but two test failures. Regardless this means that this PR fixes the broken build against dev libtiledb

@kounelisagis
Copy link
Member Author

I agree, @jdblischak. However, I don't understand why these two tests are failing. I merged from the dev branch, so these issues should have been fixed by now.

@kounelisagis
Copy link
Member Author

I guess you have to re-run the workflow from the beginning after I merged. If this is the case, everything is ok.

@jdblischak
Copy link
Contributor

However, I don't understand why these two tests are failing. I merged from the dev branch, so these issues should have been fixed by now.

The nightly pipeline checked out b0aaccf (log), so it should have had the latest changes from dev from your merge.

I also don't know why the 2 tests continue to fail. But I don't believe they are related to this PR. Thus I think we should merge this PR, and then we can continue to troubleshoot the failing tests if necessary.

@jdblischak
Copy link
Contributor

The nightly pipeline checked out b0aaccf (log), so it should have had the latest changes from dev from your merge.

Oops. I didn't realize that you had already restarted it. You are correct that on the first attempt it didn't have the latest changes from dev. FWIW the number of failing tests reduced from 3 to 2 after merging dev.

https://github.com/TileDB-Inc/centralized-tiledb-nightlies/actions/runs/11407797939/attempts/1

@ihnorton ihnorton merged commit d8109c3 into dev Oct 18, 2024
15 checks passed
@ihnorton ihnorton deleted the agis/add-new-argument-for-Group--add_member branch October 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants