-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for amplitude_bell size offset #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the prompt fix (+ test cases). I like the test but have some suggestions for improvements.
👍🏼
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 89.99% 90.00% +0.01%
==========================================
Files 53 53
Lines 2088 2091 +3
==========================================
+ Hits 1879 1882 +3
Misses 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Mypy still fails on the test-file. You can add |
As promised in #49 here is the fix for the amplitude_bell size offset (fixes #49).
I’m not very familiar with unittest TestCase-Classes, @CodeLionX could you please review the
tests/test_generator/test_lengths.py
?There might be a more efficient way to check for the valid generation of anomalies under different length values?
Greetings and thanks for the very fast reply.