Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Valid File Implimentation #31

Closed
wants to merge 1 commit into from

Conversation

Anderson-Cooper
Copy link

This is useful so that you can transfer any file you want.

Limiting it to just standard files causes some bugs like in my Issue i submitted.

#30

@debrouxl
Copy link

If you've made sure that the file you've created is indeed correct and that you're transferring it to the appropriate calculator model, then the file format detection code might need a fix, though that's rather unlikely.
However, removing both file format checking and user feedback about an invalid file is quite a wrong way to address your immediate problem - the computer software world needs more checks, not fewer :)

@Anderson-Cooper
Copy link
Author

If you've made sure that the file you've created is indeed correct and that you're transferring it to the appropriate calculator model, then the file format detection code might need a fix, though that's rather unlikely. However, removing both file format checking and user feedback about an invalid file is quite a wrong way to address your immediate problem - the computer software world needs more checks, not fewer :)

True, but limiting it to only TI exclusive files doesn't seem like a good idea in my opinion.

@adriweb
Copy link

adriweb commented Feb 11, 2022

Why? If it's invalid the calculator won't do anything with it anyway, if not straight up reject it.
If you've found a bug where a legitimate file could not be transferred, that would be worth fixing, as Lionel said!

@Anderson-Cooper
Copy link
Author

Why? If it's invalid the calculator won't do anything with it anyway, if not straight up reject it. If you've found a bug where a legitimate file could not be transferred, that would be worth fixing, as Lionel said!

fair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants