feat: vscode extension #4104

benfdking · 2025-04-09T15:13:25Z

Initial scope:

vscode/react/src/components/search/SearchList.tsx

+          <small
+            className="block text-neutral-600 italic overflow-hidden whitespace-nowrap overflow-ellipsis"
+            dangerouslySetInnerHTML={{
+              __html: highlightMatch(index, search),


vscode/react/src/components/search/SearchList.tsx

+          title={item[displayBy]}
+          className="font-bold"
+          dangerouslySetInnerHTML={{
+            __html: highlightMatch(item[displayBy], search),


To fix the issue, we need to ensure that any HTML injected into the DOM via dangerouslySetInnerHTML is sanitized to prevent XSS. The best approach is to use a library like dompurify to sanitize the output of highlightMatch. This ensures that any potentially malicious input is neutralized before being rendered as HTML.

Steps to fix:

Install the dompurify library if it is not already installed.

Import dompurify into the file.

Use DOMPurify.sanitize to sanitize the output of highlightMatch before passing it to dangerouslySetInnerHTML.

mykalmax · 2025-04-15T18:24:29Z

vscode/extension/src/common/constants.ts

+
+import * as path from 'path'
+
+const folderName = path.basename(__dirname)


FOLDER_NAME ?

mykalmax · 2025-04-15T18:37:12Z

vscode/extension/src/common/setup.ts

+export function loadServerDefaults(): IServerInfo {
+    const packageJson = path.join(EXTENSION_ROOT_DIR, 'package.json')
+    const content = fs.readFileSync(packageJson).toString()
+    const config = JSON.parse(content)


config is unused

mykalmax · 2025-04-15T18:41:18Z

vscode/extension/src/common/utilities.ts

+        let rootWorkspace = workspaces[0]
+        let root = undefined
+        for (const w of workspaces) {
+            if (await fs.pathExists(w.uri.fsPath)) {


should we juts use pathExistsSync ?

mykalmax · 2025-04-15T18:47:09Z

vscode/extension/src/sqlmesh/sqlmesh.ts

+ * 
+ * @returns The sqlmesh executable for the current workspace.
+ */
+export const sqlmesh_exec = async (): Promise<Result<sqlmesh_exec, string>> => {


should we use camelCase ?

mykalmax · 2025-04-16T16:07:41Z

vscode/react/src/routes/index.tsx

+          target="_blank"
+          rel="noopener noreferrer"
+        >
+          Learn React


example file

mykalmax · 2025-04-16T16:08:31Z

vscode/react/src/logo.svg

mykalmax · 2025-04-16T16:11:46Z

vscode/react/src/hooks/vscode.ts

+            // Use a different variable name to avoid conflict with the parameter
+            const eventPayload = {
+                key: callbackName,
+                payload: payload,
+            }
+            window.parent.postMessage({
+                key: "vscode_callback",
+                payload: eventPayload,
+            }, '*');


maybe just use object directly payload: { ... }?

mykalmax · 2025-04-16T16:12:31Z

vscode/react/index.html

example file ?

mykalmax · 2025-04-16T16:13:36Z

vscode/extension/src/test/extension.test.ts

+// You can import and use all API from the 'vscode' module
+// as well as import your extension to test it
+import * as vscode from 'vscode'
+// import * as myExtension from '../../extension';


mykalmax · 2025-04-16T16:16:25Z

vscode/extension/src/webviews/lineagePanel.ts

+        if (message && message.key) {
+          if (message.key === "vscode_callback") {


i think you can just if (message?.key === "vscode_callback") { ... } else {}

mykalmax · 2025-04-16T16:18:03Z

vscode/extension/src/webviews/lineagePanel.ts

+    webviewView.webview.onDidReceiveMessage(
+      async (message) => {
+        console.log("message received", message);
+        if (message && message.key) {


should we have a dedicated ConsoleLog() function to use when we need to log something and treat native console.log as part of dev debugging that needs to be removed ?

mykalmax · 2025-04-16T16:22:09Z

vscode/extension/src/lsp/lsp.ts

+        // synchronize: {
+            // fileEvents: workspace.createFileSystemWatcher('**/*.{sql,py}'),
+        // }


mykalmax · 2025-04-16T16:24:17Z

vscode/extension/src/common/python.ts

+    if (_api) {
+        return _api
+    }
+    _api = await PythonExtension.api()


maybe _api = _api || await PythonExtension.api()

mykalmax · 2025-04-16T16:27:16Z

vscode/extension/src/common/python.ts

+    try {
+        const api = await getPythonExtensionAPI()
+
+        if (api) {
+            disposables.push(
+                api.environments.onDidChangeActiveEnvironmentPath(async (e) => {
+                    const environment = await api.environments.resolveEnvironment(e.path)
+                    const isVirtualEnv = environment?.environment !== undefined
+                    const binPath = isVirtualEnv ? environment?.environment?.folderUri.fsPath : undefined
+
+                    onDidChangePythonInterpreterEvent.fire({ 
+                        path: [e.path], 
+                        resource: e.resource?.uri,
+                        isVirtualEnvironment: isVirtualEnv,
+                        binPath
+                    })
+                }),


it is trying to catch Error initializing python and i think if await getPythonExtensionAPI() returns null that kinda like an error we want to catch here but having if (api) { prevents that

mykalmax · 2025-04-16T16:47:37Z

vscode/extension/src/common/utilities.ts

+    const level = logLevelToTrace(channelLogLevel <= globalLogLevel ? channelLogLevel : globalLogLevel)
+    return level
+}


maybe just return logLevelToTrace(channelLogLevel <= globalLogLevel ? channelLogLevel : globalLogLevel)

registered logging [ci skip] format works making progress making progress sharing node modules creating the docs progress getting react server to show making progress with the server temp get calling api now need to add lineage tab making progress on vscode lineage temp progress: showing the lineage graph [ci skip] cleaning up lineage [ci skip] added ability to open files temp [ci skip] trying to implement lsp [ci skip] temp [ci skip] test [ci skip] temp [ci skip] temp [ci skip] temp [ci skip]

github-advanced-security bot found potential problems Apr 9, 2025

View reviewed changes

benfdking force-pushed the vscode_extension branch 5 times, most recently from 8a0b89e to 2673372 Compare April 11, 2025 22:30

mykalmax reviewed Apr 15, 2025

View reviewed changes

mykalmax reviewed Apr 16, 2025

View reviewed changes

vscode/react/src/routes/index.tsx

target="_blank"

rel="noopener noreferrer"

>

Learn React

Copy link

Member

mykalmax Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example file

mykalmax reviewed Apr 16, 2025

View reviewed changes

vscode/react/src/logo.svg Outdated

Copy link

Member

mykalmax Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react logo

mykalmax reviewed Apr 16, 2025

View reviewed changes

vscode/react/index.html Outdated

Copy link

Member

mykalmax Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example file ?

mykalmax reviewed Apr 16, 2025

View reviewed changes

benfdking marked this pull request as draft April 17, 2025 15:45

benfdking force-pushed the vscode_extension branch 8 times, most recently from 5cc30c2 to daa2f80 Compare April 24, 2025 11:47

benfdking force-pushed the vscode_extension branch 4 times, most recently from cdb81d1 to a019d1c Compare April 24, 2025 11:53

benfdking force-pushed the vscode_extension branch from a019d1c to 9d2ab34 Compare April 24, 2025 11:55

@@ -1,2 +1,3 @@
             import React, { Fragment, useMemo, useRef, useState } from 'react'
+            import DOMPurify from 'dompurify'
             import Input from '@/components/input/Input'
@@ -333,3 +334,3 @@
                       dangerouslySetInnerHTML={{
-                        __html: highlightMatch(item[displayBy], search),
+                        __html: DOMPurify.sanitize(highlightMatch(item[displayBy], search)),
                       }}

@@ -23,3 +23,4 @@
                 "react-dom": "^19.0.0",
-                "tailwindcss": "^4.1.3"
+                "tailwindcss": "^4.1.3",
+                "dompurify": "^3.2.5"
               },

Package	Version	Security advisories
dompurify (npm)	3.2.5	None

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: vscode extension #4104

feat: vscode extension #4104

benfdking commented Apr 9, 2025 •

edited

Loading

Check warning

Check warning

Copilot Autofix

mykalmax Apr 15, 2025

mykalmax Apr 15, 2025

mykalmax Apr 15, 2025

mykalmax Apr 15, 2025

mykalmax Apr 16, 2025

mykalmax Apr 16, 2025

mykalmax Apr 16, 2025

mykalmax Apr 16, 2025

mykalmax Apr 16, 2025

mykalmax Apr 16, 2025

mykalmax Apr 16, 2025

mykalmax Apr 16, 2025

mykalmax Apr 16, 2025

mykalmax Apr 16, 2025

mykalmax Apr 16, 2025


		import * as path from 'path'

		const folderName = path.basename(__dirname)

		if (message && message.key) {
		if (message.key === "vscode_callback") {

feat: vscode extension #4104

Are you sure you want to change the base?

feat: vscode extension #4104

Conversation

benfdking commented Apr 9, 2025 • edited Loading

Check warning

Check warning

Copilot Autofix

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benfdking commented Apr 9, 2025 •

edited

Loading