-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Original TV platform fork with refactored Inputs, config.schema.json, and updated eiscp fork #78
Conversation
…. Inputs are populated from ecisp query. Input changing has issues with my model (TX-NR515). Volume from remote doesn't work.
…t input sources based on list in config. Clean up logging a little. Edit README.
[2019-2-11 19:56:12] Loaded plugin: homebridge-onkyo [2019-2-11 19:56:12] Registering accessory 'homebridge-onkyo-tv.Onkyo-tv'
Fix example accessory config (rename to Onkyo-tv)
…lass and starting platform work.
…Update README.md.
# Conflicts: # README.md
Convert from Switch to new TV accessory in iOS 12.2 - new new branch devel
Do not use an absolute path to node_modules when importing eiscp-commands.json
Remove duplicate power state characteristic for TV service.
…e speaker service.
Copied from homebridge-roku, though I don't quite understand why this works yet and my code didn't.
Not sure what Platform buys us at this stage but it would break everyone on upgrade. Additional cleanup.
- Remove legacy Switch service - Make Volume Dimmer enabled by default
Fix issue where inputs were missing unless they existed on TX-NR609
… and values of 'input' and 'label'. Remove some unused code. Add config.schema.json for ui-x support.
…n file. Should be easier for people to read.
@solowalker27 I see that this PR is based on an older version. Even fixed typos in the readme are going to be reintroduced with this PR. |
Yes, this is just my original fork for HomeKit TV support before your changes, with a couple minor updates and tweaks. That was just easiest and quickest for me to do since I’ve been using it the whole time and it’s been working fine for me. I can see if I can make time to look into the issues you’re having and try to fix them directly, or perhaps apply more targeted changes from my fork. I’m not sure if that would be faster and easier or if trying to adapt your tests, typo corrections, and other contributions back into my fork. I’ll see what I can do in the near future. |
…. Remove RxType.js as that was only used by the legacy Switch Service.
Closing in favor of #80 |
Before submitting your PR, please review the following checklist:
master
branchMy branch doesn't have tests at the moment.
Directly addresses:
Merge back (ToddGreenfield & SoloWalker) projects into ToddGreenfield as looks like Todd is now actively maintaining original codebase (will cross post) solowalker27/homebridge-onkyo#13
Merge back fork (ToddGreenfield & SoloWalker) projects into ToddGreenfield as looks like Todd is now actively maintaining original codebase (will cross post) #70
Can't use TX-NR676 #75
Touches code around and thus potentially addresses (this should at least be looked at again after this):
#74
#72
#71
#68
#63
Due to how far our forks have drifted, not sure this will be considered "small".
As requested by several people, this PR would merge back in my fork where I originally added HomeKit TV support and converted to a Homebridge Platform. I have refactored the Input code so it's now (hopefully) more understandable and maintainable as well as more compatible with ui-x, including coming with a config.schema.json that works. I also found a more recent node-eiscp fork that had updated model list, increasing the number of explicitly supported and potentially compatible models.