Fix security manager checks not being executed properly #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The security manager incorrectly assumed executed methods were his and allowed unfiltered access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The security manager wrongly thought almost every access was initiated by itself, resulting in it being way too lenient.
Closes
#22 Unfiltered file access
Resolution
Fix the security manager believing calls originated from itself and add some small regression tests for this case.
Future possible problems
Checking whether the security manager appears in the callstack might be problematic, if a malicious user is able to inject it in there. Not quite sure if that is possible, but it is not ideal. I am more than happy to receive some nicer solution or hints, if anybody has some.
Addendum
For some reason, the test files were formatted with a different formatter, so the diff of that file is basically useless. The last two methods are new.