Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:Add pagination to get campaign by category( issue#33) #37

Conversation

Iknow6aint
Copy link
Contributor

@Iknow6aint Iknow6aint commented Feb 22, 2025

-For this implementation i had to crate some pagination interfaces that i added to the DTOs folder
-In the getCampaignsByCategory endpoint i added a new pagination parameter with the interface paginationInput , the pagination inputs holds the cursor,limit and skip varialbles.
-the endpoint now returns a new object PaginatedCampaigns that returns the campaigns array and the pagination meta data(total count and hasNextPage)

fixes #33

@Iknow6aint Iknow6aint changed the title Add pagination to get campaign by category Feat:Add pagination to get campaign by category( issue#33) Feb 22, 2025
@Oshioke-Salaki
Copy link
Contributor

Please make sure that all checks are passing @Iknow6aint

@Iknow6aint
Copy link
Contributor Author

i have made the changes

Copy link
Collaborator

@EjembiEmmanuel EjembiEmmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have so many files changed? It's difficult to review like this, please include only files you worked on. Also we're using yarn packager so get rid of package.lock.json

@Iknow6aint
Copy link
Contributor Author

I have redone the implementation on a clean branch should I make a pr from there?

@Oshioke-Salaki
Copy link
Contributor

Oshioke-Salaki commented Feb 27, 2025

yes you can. then close this one

@Iknow6aint Iknow6aint closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify getCampaignsByCategory to Use Cursor-Based Pagination
3 participants