BT-129 - IRS ERC3643 implementation #233
Conversation
| * @dev See {IIdentityRegistryStorage-bindIdentityRegistry}. | ||
| */ | ||
| function bindIdentityRegistry() external view override { | ||
| revert ContractIsReadOnly(); |
There was a problem hiding this comment.
just do nothing, don't revert, otherwise the factory won't be able to use this contract, as the factory will try to bind
| * @dev See {IIdentityRegistryStorage-storedInvestorCountry}. | ||
| */ | ||
| function storedInvestorCountry(address _userAddress) external view override returns (uint16) { | ||
| return _identities[_userAddress].investorCountry; |
There was a problem hiding this comment.
just return 42 or something, by default, in case the _identities[_userAddress].investorCountry value is 0
Should have a way for OID owners to publish their country code there in a decentralized way, so that a wallet that is linked to an OID on the IdFactory can update their own country code on this contract
| error MaxIRByIRSReached(uint256 _max); | ||
|
|
||
|
|
||
| contract IdentityRegistryStorage is IERC3643IdentityRegistryStorage, AgentRoleUpgradeable, IRSStorage, IERC165 { |
There was a problem hiding this comment.
call this contract another way, we already have an identity registry storage
There was a problem hiding this comment.
call it GlobalIRS or something
| /** | ||
| * @dev See {IIdentityRegistryStorage-addIdentityToStorage}. | ||
| */ | ||
| function addIdentityToStorage() external view override onlyAgent { |
There was a problem hiding this comment.
the whole idea of this contract is to provide a decentralized way of managing the links between OIDs and wallet addresses, therefore i think we should allow users to add and remove wallets linked to their OID, but to make sure they are really owning these wallets, they should provide a signature done by this wallet to make the transaction happen. the transaction should be called either by a wallet that is a management key on the OID or by the OID itself (through approve/execute)
| /** | ||
| * @dev See {IIdentityRegistryStorage-removeIdentityFromStorage}. | ||
| */ | ||
| function removeIdentityFromStorage() external view override onlyAgent { |
There was a problem hiding this comment.
same comment as the addIdentity stuff, but in this case no need of a signature. A wallet can be removed by another wallet that is a management key on the OID or by the OID itself, note that you cannot remove the initial wallet linked to the OID on the IDFactory as that one is registered there forever
| * @dev See {IIdentityRegistryStorage-storedIdentity}. | ||
| */ | ||
| function storedIdentity(address _userAddress) external view override returns (IIdentity) { | ||
| return IIdentity(_iidFactory.getIdentity(_userAddress)); |
There was a problem hiding this comment.
fetch from IdFactory only the first time, and store locally, it costs less gas to call internal memory
No description provided.