Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for PDShading waiting to merge #384

Open
anyongjin opened this issue Mar 22, 2022 · 1 comment · May be fixed by #388
Open

support for PDShading waiting to merge #384

anyongjin opened this issue Mar 22, 2022 · 1 comment · May be fixed by #388
Labels
type: enhancement Request to add/improve a feature

Comments

@anyongjin
Copy link
Contributor

anyongjin commented Mar 22, 2022

I found that PDshading support has not been added to this repository, and the rendering and creation about shading will also be ignored.
I added support for shading(type 1 to type 7) with the latest version of pdfbox code and the android.graphics library.
Most of the code is just simple modifications of pdfbox.
and unit tests for types 2,3,4 are also added.

The source code is latest two commits in here;

Here is 3 file to test shading 2,3,4:
shading2.pdf
shading3.pdf
shading4.pdf

Please create a new branch named shading to merge and test.
or can i just create a pull request to master?

waiting for you reply,
thank you

Edit 03/23

I fixed an index error bug, and optimized some heavy functions.
big_sm (1).pdf
it would cost about 140s to render the big_sm (1).pdf to images.
Now it would cost just about 33s.
here is the method cost log files:
after_optimize.log
before_optimize.log

@anyongjin anyongjin added the type: enhancement Request to add/improve a feature label Mar 22, 2022
@TomRoush
Copy link
Owner

If you move some of your commits into separate branches in your repository using rebase / cherry-pick, you can open multiple pull requests here targeting TomRoush/master with different sets of changes. For example, you could create a branch called "add-pdshading" that starts at the latest commit from TomRoush/master and then push only your PDShading changes to that branch. That way it is completely separate from any other changes you might make

@TomRoush TomRoush added this to the v2.0.18.0 milestone Mar 27, 2022
@TomRoush TomRoush removed this from the v2.0.18.0 milestone Apr 6, 2022
@TomRoush TomRoush linked a pull request Jun 10, 2022 that will close this issue
@TomRoush TomRoush added this to the v2.0.24.0 milestone Jun 10, 2022
@TomRoush TomRoush removed this from the v2.0.24.0 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Request to add/improve a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants