add shading(type 1 to type 7) rendering/create support #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. add unit test for shading 2,3,4 3. optimize performance while image decoding, soft masking. 'from8bit' is about 10x faster, `applyMask` is 2x faster. 4. fix conflicts
|
@anyongjin Wanted to give you an update on this PR. I've looked through everything you've written and it all looks great. I made some formatting changes and rebased to get it up to date with master. In comparing the rendering results of all the test PDFs, I did notice some regressions (and some bugs that were fixed). I'm going to work on debugging the issues and maybe split some of the changes into different PRs so they can be included in 2.0.24.0 even if all the changes aren't ready |
|
Thank you for your excellent work ! you are really amazing (๑•̀ㅂ•́)و✧ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applyMaskis 2x faster.related issue 384
I've ’tested more than a dozen files and solved three bugs.
But there may be still some bugs and need more test.
So please merge this commit to a separate branch, and release it after full testing.
Thank you.