CI: add docker images #1633
Merged
CI: add docker images #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
casperdcl
force-pushed
the
docker-image
branch
from
ee9d630 to
b69e24c
Compare
casperdcl
force-pushed
the
docker-image
branch
from
c13d318 to
0e644bc
Compare
casperdcl
commented
Dec 20, 2023
paskino
reviewed
Dec 20, 2023
paskino
reviewed
Dec 20, 2023
paskino
previously requested changes
Dec 20, 2023
- fixes #933
casperdcl
force-pushed
the
docker-image
branch
from
26d3768 to
34263a0
Compare
casperdcl
force-pushed
the
docker-image
branch
from
34263a0 to
1fcbd36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Build & push docker image to ghcr.io.
Happily this is 2x faster than the conda build job (which was already 2x faster thanks to
mambabuildin #1607).With caching (e.g. subsequent pushes to a PR), it's 10x faster ⚡.
before CI: update docs & tidy workflow #1634 is merged, the diff can be viewed at https://github.com/TomographicImaging/CIL/compare/ci-docs-tidy..docker-imageDockerfilebased on https://github.com/stfc/cloud-docker-images/blob/master/jupyter-cil-notebook/Dockerfileghcr.io/tomographicimaging/cilmasteras well aslatest+ semver tagsactually- probably needs CI matrices #1598 firstconda publish cilfirst before trying toinstall cilin the docker image (currently Anvil not GHA handlesconda publish)/.github/workflows/README.md/README.mdTODO in follow-ups: #1639
Describe any testing you have performed
Link relevant issues
Fixes #933
Checklist when you are ready to request a review
I have added docstrings in line with the guidance in the developer guideI have implemented unit tests that cover any new or modified functionalityContribution Notes
Please read and adhere to the developer guide and local patterns and conventions.