-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add jekyll landing page #1699
Conversation
d58c423
to
d32b8e6
Compare
f3eb021
to
5a843cc
Compare
5a843cc
to
33f1b08
Compare
0b3bcde
to
263d6a6
Compare
263d6a6
to
98fa31a
Compare
cc46c34
to
b8034ef
Compare
What is the best way for us to review this? Are there build instructions so we can view it, or could you set up a (short) meeting to show us it if you have it running locally? |
Instructions for testing are included in the docs in this PR. I ran this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's get it in so we have a landing page we can then adapt later on
not a quick fix unfortunately, but added to #1579 :) |
Describe your changes
Using jekyll (picked https://phlow.github.io/feeling-responsive which seems to be more maintained than https://mmistakes.github.io/minimal-mistakes)
content(moved to docs versions + updates #1579)/assets/img/
){{site.basurl}}
fix navigation dropdown relative links Phlow/feeling-responsive#276auto-fix_config.yml:url
docs/Makefile
make -C docs dirhtml web-deps web serve
DocumentationHTML
unzip intoCIL
subfolder before runninghttp.server
DocumentationHTML
: use/prnum_merge
instead of/nightly
add more "widgets"moved to docs versions + updates #1579refs.bib
entriesDescribe any testing you have performed
Link relevant issues
Checklist when you are ready to request a review
I have added docstrings in line with the guidance in the developer guideI have implemented unit tests that cover any new or modified functionalityCHANGELOG.md has been updated with any functionality changeContribution Notes
Please read and adhere to the developer guide and local patterns and conventions.