Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: CUDA tests #1729

Merged
merged 9 commits into from
Mar 25, 2024
Merged

CI: CUDA tests #1729

merged 9 commits into from
Mar 25, 2024

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Feb 27, 2024

Describe your changes

before this PR follow-up PRs
conda conda - (move to conda-forge, halve our CI times)
- test(py3.8,np1.21/py3.10,np1.24) test(pyX.X,npX.X,mac/win/nix)
- (jenkins) test-cuda test-cuda(pyX.X,npX.X)
  • add some filters so test-cuda only runs GPU (not CPU) tests (brings down test time from ~15 min to ~2min)
  • adds TESTS_FORCE_GPU to fix CI: unskip expected tests #1731
  • update README.md
  • update .github/workflows/README.md

Describe any testing you have performed

see CI

Link relevant issues

part of #1598
fixes #1731
closes #1640

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@casperdcl casperdcl self-assigned this Feb 27, 2024
@casperdcl casperdcl added enhancement New feature or request gh-actions labels Feb 27, 2024
@casperdcl casperdcl force-pushed the gha-self-hosted branch 6 times, most recently from 9ffeba5 to cf6e346 Compare February 27, 2024 21:04
@casperdcl casperdcl marked this pull request as ready for review February 27, 2024 21:36
@casperdcl casperdcl changed the title gha self hosted CI: CUDA tests Feb 27, 2024
@casperdcl casperdcl requested a review from gfardell February 27, 2024 22:37
@casperdcl casperdcl force-pushed the gha-self-hosted branch 2 times, most recently from 3aa74e9 to 600054f Compare March 8, 2024 13:40
@casperdcl
Copy link
Member Author

casperdcl commented Mar 11, 2024

btw bizarre docker failure:

======================================================================
FAIL: test_Function (test_functions.TestFunction)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/CIL/Wrappers/Python/test/test_functions.py", line 93, in test_Function
    self.assertEqual(a2, g(d))
AssertionError: 1.0496462747793063 != 1.0496462747793065

caused by the last commit:

- - libgcc-ng
- - libstdcxx-ng
+ - libgcc-ng     # [linux]
+ - libstdcxx-ng  # [linux]
+ - _openmp_mutex # [linux]

... any ideas?

@MargaretDuff
Copy link
Member

MargaretDuff commented Mar 11, 2024

btw bizarre docker failure

If you change it to self.assertAlmostEqual it will pass 😃 Not sure why it failed though

Copy link
Member

@gfardell gfardell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only spotted one area where the tests have both tigre and astra tests. There may also be some tests that are astra-cpu only so I think these will be caught to - in practise a few extra tests probably don't matter though.

Please could you document the style and keywords in the contribution guide so we can make sure future unit-tests conform.

@casperdcl
Copy link
Member Author

document the style and keywords in the contribution guide so we can make sure future unit-tests conform

it's a complete unacceptable mess with no consistent style nor keywords to conform to 😅. Definitely worth opening a separate issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gfardell any objections to this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objections!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, though I presume Windows users will have to manually remove the # [linux] lines...

@gfardell
Copy link
Member

btw bizarre docker failure:

======================================================================
FAIL: test_Function (test_functions.TestFunction)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/CIL/Wrappers/Python/test/test_functions.py", line 93, in test_Function
    self.assertEqual(a2, g(d))
AssertionError: 1.0496462747793063 != 1.0496462747793065

caused by the last commit:

- - libgcc-ng
- - libstdcxx-ng
+ - libgcc-ng     # [linux]
+ - libstdcxx-ng  # [linux]
+ - _openmp_mutex # [linux]

... any ideas?

Just floating point precision. It's a bad test!

@casperdcl casperdcl merged commit 755801d into master Mar 25, 2024
8 checks passed
@casperdcl casperdcl deleted the gha-self-hosted branch March 25, 2024 17:27
@casperdcl casperdcl mentioned this pull request Mar 25, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CI: unskip expected tests
4 participants