-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: CUDA tests #1729
CI: CUDA tests #1729
Conversation
9ffeba5
to
cf6e346
Compare
8505734
to
fc4a385
Compare
3aa74e9
to
600054f
Compare
btw bizarre docker failure: ======================================================================
FAIL: test_Function (test_functions.TestFunction)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/CIL/Wrappers/Python/test/test_functions.py", line 93, in test_Function
self.assertEqual(a2, g(d))
AssertionError: 1.0496462747793063 != 1.0496462747793065 caused by the last commit: - - libgcc-ng
- - libstdcxx-ng
+ - libgcc-ng # [linux]
+ - libstdcxx-ng # [linux]
+ - _openmp_mutex # [linux] ... any ideas? |
If you change it to |
72b695e
to
c599d4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only spotted one area where the tests have both tigre and astra tests. There may also be some tests that are astra-cpu only so I think these will be caught to - in practise a few extra tests probably don't matter though.
Please could you document the style and keywords in the contribution guide so we can make sure future unit-tests conform.
it's a complete unacceptable mess with no consistent style nor keywords to conform to 😅. Definitely worth opening a separate issue. |
c599d4d
to
6848cbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gfardell any objections to this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no objections!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, though I presume Windows users will have to manually remove the # [linux]
lines...
Just floating point precision. It's a bad test! |
Describe your changes
conda
conda
-
(move to conda-forge, halve our CI times)-
test(py3.8,np1.21/py3.10,np1.24)
test(pyX.X,npX.X,mac/win/nix)
-
(jenkins)test-cuda
test-cuda(pyX.X,npX.X)
test-cuda
only runs GPU (not CPU) tests (brings down test time from ~15 min to ~2min)TESTS_FORCE_GPU
to fix CI: unskip expected tests #1731README.md
.github/workflows/README.md
Describe any testing you have performed
see CI
Link relevant issues
part of #1598
fixes #1731
closes #1640
Checklist when you are ready to request a review
I have added docstrings in line with the guidance in the developer guideI have implemented unit tests that cover any new or modified functionalityCHANGELOG.md has been updated with any functionality changeContribution Notes
Please read and adhere to the developer guide and local patterns and conventions.