-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update random array from test_stepsizes.TestStepSizeBB.test_bb_converge #2052
Conversation
I think that the For one, it is a functional test and you are testing that 2 algorithms converge to the same solution with some accuracy without reaching convergence (i.e. infinite iterations). I would say that a better check would be to:
|
The windows build seems to be working with this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, seems the seed is no longer needed
Co-authored-by: Laura Murgatroyd <[email protected]> Signed-off-by: Margaret Duff <[email protected]>
Works on windows! Thanks @MargaretDuff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with the test functionality - happy to merge @hrobarts if the windows build consistently passes
Changes
test_stepsizes.TestStepSizeBB.test_bb_converge failed in windows because of random array, this PR updates to a fixed array
Testing you performed
Related issues/links
Closes #2064
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.