-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove version of mamba from GHA #2075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edoardo Pasca <[email protected]>
Signed-off-by: Margaret Duff <[email protected]>
MargaretDuff
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass on the full matrix, happy to approve
Closes #2072 |
Signed-off-by: Edoardo Pasca <[email protected]>
lauramurgatroyd
approved these changes
Feb 14, 2025
Let's merge #2047 to remove all warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GHA fails on the conda task because the
conda-incubator/setup-miniconda
tries to installmamba
version 1.15.CIL/.github/workflows/build.yml
Lines 122 to 126 in 98860db
The error we incur is the following.
Probably that's a too old version of mamba which is incompatible with the new conda with python 3.13.
I suggest to remove the pinned version
1.5
of mamba and opt for*
, see https://github.com/conda-incubator/setup-miniconda#example-6-mambaLinked Issues
supersedes Remove defaults channel from requirements-test.yml #2047conda-forge
channel only:Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.