Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version of mamba from GHA #2075

Merged
merged 4 commits into from
Feb 14, 2025
Merged

remove version of mamba from GHA #2075

merged 4 commits into from
Feb 14, 2025

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Feb 13, 2025

Description

GHA fails on the conda task because the conda-incubator/setup-miniconda tries to install mamba version 1.15.

- uses: conda-incubator/setup-miniconda@v3
with:
python-version: ${{ matrix.python-version }}
mamba-version: "1.5"
channels: conda-forge

The error we incur is the following.

/usr/share/miniconda/condabin/conda install --name base mamba=1.5
  CI detected...
  Channels:
   - conda-forge
   - defaults
  Platform: linux-64
  Collecting package metadata (repodata.json): ...working... done
  Solving environment: ...working... failed
  Warning: 
  LibMambaUnsatisfiableError: Encountered problems while solving:
    - nothing provides _python_rc needed by python-3.13.0rc2-h6355ac2_0_cp313t

Probably that's a too old version of mamba which is incompatible with the new conda with python 3.13.

I suggest to remove the pinned version 1.5 of mamba and opt for *, see https://github.com/conda-incubator/setup-miniconda#example-6-mamba

Linked Issues

/usr/share/miniconda/condabin/mamba create --name test python=3.10
  Warning: warning  libmamba 'repo.anaconda.com', a commercial channel hosted by Anaconda.com, is used

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@paskino paskino requested a review from MargaretDuff February 13, 2025 09:27
@MargaretDuff
Copy link
Member

All tests pass:
image

Copy link
Member

@MargaretDuff MargaretDuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass on the full matrix, happy to approve

@MargaretDuff
Copy link
Member

Closes #2072

@MargaretDuff MargaretDuff linked an issue Feb 13, 2025 that may be closed by this pull request
Signed-off-by: Edoardo Pasca <[email protected]>
@paskino
Copy link
Contributor Author

paskino commented Feb 14, 2025

Let's merge #2047 to remove all warnings.

@lauramurgatroyd
Copy link
Member

lauramurgatroyd commented Feb 14, 2025

I don't think #2047 will remove all of the warnings - when I originally looked at them I thought this would but actually the issue is different: #2051

But anyway the defaults channel is not needed and should be removed from the env file

@lauramurgatroyd lauramurgatroyd merged commit c1ef11c into master Feb 14, 2025
10 checks passed
@lauramurgatroyd lauramurgatroyd deleted the GHA_mamba branch February 14, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Github actions failing conda-matrix tests on master
3 participants