Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photon datacard #420

Open
wants to merge 14 commits into
base: photons_histEFT
Choose a base branch
from
Open

Photon datacard #420

wants to merge 14 commits into from

Conversation

bryates
Copy link
Contributor

@bryates bryates commented Jun 29, 2024

This PR updates the datacard maker to handle the new ttgamma process. This is based on the datacard maker from the master branch, so it looks like a lot more changes than there actually are.

@bryates bryates requested review from Andrew42, abasnet97 and sscruz June 29, 2024 19:25
@bryates bryates changed the base branch from photons to photons_histEFT July 1, 2024 18:45
@bryates
Copy link
Contributor Author

bryates commented Jul 2, 2024

This PR is pretty simple, but the CI is failing since we've changed the channels upstream in the analysis processor. I don't think that should hold up this PR, since it's targeting the photon branch. @Andrew42 and @abasnet97 did either of you have comments on this PR?

@abasnet97
Copy link
Collaborator

To me, the PR looks good. I think Brent said that the photon related changes were pretty simple and were added on top of pre-exisiting changes made in the master branch (which have been verified to work).

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 24.38%. Comparing base (30b3af4) to head (fb6238d).

Files with missing lines Patch % Lines
topeft/modules/datacard_tools.py 50.00% 6 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           photons_histEFT     #420      +/-   ##
===================================================
+ Coverage            24.36%   24.38%   +0.02%     
===================================================
  Files                   35       35              
  Lines                 5085     5093       +8     
===================================================
+ Hits                  1239     1242       +3     
- Misses                3846     3851       +5     
Flag Coverage Δ
unittests 24.38% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants