-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photon datacard #420
base: photons_histEFT
Are you sure you want to change the base?
Photon datacard #420
Conversation
This PR is pretty simple, but the CI is failing since we've changed the channels upstream in the analysis processor. I don't think that should hold up this PR, since it's targeting the photon branch. @Andrew42 and @abasnet97 did either of you have comments on this PR? |
To me, the PR looks good. I think Brent said that the photon related changes were pretty simple and were added on top of pre-exisiting changes made in the master branch (which have been verified to work). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## photons_histEFT #420 +/- ##
===================================================
+ Coverage 24.36% 24.38% +0.02%
===================================================
Files 35 35
Lines 5085 5093 +8
===================================================
+ Hits 1239 1242 +3
- Misses 3846 3851 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This PR updates the datacard maker to handle the new ttgamma process. This is based on the datacard maker from the master branch, so it looks like a lot more changes than there actually are.