Improve string source handling
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Added
- A string `source` can now contain `{{term}}`, to accomodate paths where `?term=XXX` isn't suitable
- This means you could now use `example.com/search/{{term}}/other-stuff`
### Fixed
- A string `source` can now contain a querystring (`?`)
- It now checks the source and adds either `?` or `&`, whichever is appropriate
### Changes
- New `initialiseEnvironment` function allows for quicker test initialisation - now more tests are being created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
sourcecan now contain{{term}}, to accommodate paths where?term=XXXisn't suitableexample.com/search/{{term}}/other-stuffFixed
sourcecan now contain a query string (?)?or&, whichever is appropriateChanges
initialiseEnvironmentfunction allows for quicker test initialisation - now more tests are being created