Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Update to Minecraft 1.20.4 #171

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

retrixe
Copy link

@retrixe retrixe commented Dec 21, 2022

This PR includes commits for 1.19.3-1.21.1 (please use the "Rebase and Merge" option instead of squashing these commits together)

Downloads: https://modrinth.com/mod/torohealth-damage-indicators-updated

Known issues:

  • Damage particles don't appear on-screen with shaders enabled in Iris. (Confirmed on 1.20-1.20.4 versions, fixed in 1.20.5+)

- Upgrade to Minecraft 1.19.3
- Upgrade to Gradle 7.6
- Upgrade to Fabric Loom 1.0
- Upgrade to Fabric Loader 0.14.11
- Upgrade to Yarn Mappings 1.19.3+build.3
- Upgrade to Fabric API 0.69.1+1.19.3
- Change build.gradle, settings.gradle to fix warnings.
- Change references that were renamed in updated Yarn (shaders, canHit).
- Migrate to JOML, which replaced Minecraft's built-in math classes.
@retrixe retrixe force-pushed the feat/1.19.3-support branch from acfe37e to 89b6382 Compare December 21, 2022 11:45
@PRRB
Copy link

PRRB commented Jan 3, 2023

Works for me. Thx.

@papertek
Copy link

1.19.2?

@retrixe
Copy link
Author

retrixe commented Jan 12, 2023

1.19.2?

The current version on CurseForge already works on 1.19.2.

@kkellogg378
Copy link

1.19.4 only partially works. Makes the in-game GUI green though

@brunociria
Copy link

@kkellogg378 how did you manage to make 1.19.4 work? I tested with the latest fabric version + latest fabric api and It crashes when looking at mobs. I also tested on quilt and I have the same issue.

@kkellogg378
Copy link

kkellogg378 commented Mar 31, 2023

@kkellogg378 how did you manage to make 1.19.4 work? I tested with the latest fabric version + latest fabric api and It crashes when looking at mobs. I also tested on quilt and I have the same issue.

Unsure. I did run it alongside Sodium and Starlight though, so rendering might have been better.

Either way, looking at a mob made it laggier and the GUI was all green, so it doesn't work well

Includes updated Gradle, Loom, Yarn, Fabric Loader and Fabric API.
@retrixe retrixe changed the title Port to Minecraft 1.19.3 Update to Minecraft 1.19.4 Apr 3, 2023
@retrixe
Copy link
Author

retrixe commented Apr 3, 2023

I'm not sure how the GUI was green and caused fps lag for you, the 1.19.3 version crashed for me with Sodium, Starlight and some other mods like Lithium/Iris/etc, just like the previous user i.e. whenever looking at mobs.

Anyway, I have pushed a 1.19.4 updated version which you can test and see if you have the same issue.

@kkellogg378
Copy link

kkellogg378 commented Apr 3, 2023

2023-04-03_12 13 54

I usually disable the HUD "showEntity" "showBar" and "showSkin" and set the inWorld "mode" to ALWAYS, and the new 1.19.4 one still changes the item I'm holding to be green (on the bright side, the hotbar is correctly colored now).

Note: I did test this with just Fabric API and Torohealth enabled, the same thing happens. Also, looking at a hostile enemy makes the held item look red

EDIT: Also no fps issues this time. I think last time my computer was just having a bad day

@retrixe
Copy link
Author

retrixe commented Apr 3, 2023

I was able to reproduce this issue, I have updated the download JAR with a version that fixes it for me (i.e. the above commit)

@kkellogg378
Copy link

Works great now! Thank you!

@Annijang
Copy link

Includes updated Gradle, Loom, Yarn, Fabric Loader and API.

This PR includes commits for both 1.19.3 and 1.19.4 (preferably use the "Rebase and Merge" option instead of squashing?)

Downloads (uploaded as ZIP cause GitHub doesn't allow JAR uploads):

hi, can you please do 1.19.2forge, 1.19.3forge, 1.19.4forge? Thanks.

@retrixe
Copy link
Author

retrixe commented Jun 4, 2023

hi, can you please do 1.19.2forge, 1.19.3forge, 1.19.4forge? Thanks.

Sorry, I don't have experience with Forge development. I could look into it in the future if I have spare time, but it's very unlikely since I have a lot of my own projects and work, hopefully someone else can step in to update the Forge version.

@Annijang
Copy link

Annijang commented Jun 5, 2023

hi, can you please do 1.19.2forge, 1.19.3forge, 1.19.4forge? Thanks.

Sorry, I don't have experience with Forge development. I could look into it in the future if I have spare time, but it's very unlikely since I have a lot of my own projects and work, hopefully someone else can step in to update the Forge version.

Can you make a version of 1.20 when it comes out? Thank you, forget it if you can't forge, it's ok.

@HowardZHY
Copy link

now 1.20.1 when

@fijidarko
Copy link

Any update for 1.20 happening?

@retrixe
Copy link
Author

retrixe commented Jun 25, 2023

Minecraft changed rendering a fair bit in 1.20, I have a partial port locally but there's some bugs before I can push it. No ETA

retrixe added 2 commits July 5, 2023 14:21
- Switch to DrawContext where needed.
- Update Gradle, Loom, FLoader/FAPI, Yarn.
Passthrough VertexConsumerProvider where needed.
@retrixe retrixe changed the title Update to Minecraft 1.19.4 Update to Minecraft 1.20.1 Jul 5, 2023
@retrixe
Copy link
Author

retrixe commented Jul 5, 2023

Done, and seems to work without any issues 🎉

@Kxsumi
Copy link

Kxsumi commented Jul 5, 2023

W

@HowardZHY
Copy link

Done, and seems to work without any issues 🎉

I think you may publish it as ToroHealth Unoffical on Modrinth

@retrixe retrixe changed the title Update to Minecraft 1.20.1 [Fabric] Update to Minecraft 1.20.1 Jul 7, 2023
@mbassie
Copy link

mbassie commented Jul 15, 2023

Bars are working, but can't seem to get the damage particles on screen on 1.20. Still using Iris/Sodium etc.

@ZsoltMolnarrr
Copy link

Hey @retrixe !
Installed the 1.20.1 version alongside Sodium and Iris.
The damage indicator particles don't show at all. Could you please fix it?

@MrOz59
Copy link

MrOz59 commented Nov 27, 2023

same here, in world bars don't appear

@qguo-gid
Copy link

anyone know who to config the bar in the mod to hearts? this is for 1.20.1 version

@retrixe retrixe changed the title [Fabric] Update to Minecraft 1.20.2 [Fabric] Update to Minecraft 1.20.4 Dec 17, 2023
@retrixe
Copy link
Author

retrixe commented Dec 17, 2023

@lxly9 I just tried the 1.20.1 version and health bars are working fine with Sodium+Iris (shaders enabled and disabled) and vanilla configurations
Can you let me know what mods you're running?

@qguo-gid I'm not sure there is such a feature, I haven't added any features to the mod and just updated it as-is

@MrOz59
Copy link

MrOz59 commented Dec 17, 2023

@lxly9 I just tried the 1.20.1 version and health bars are working fine with Sodium+Iris (shaders enabled and disabled) and vanilla configurations Can you let me know what mods you're running?

@qguo-gid I'm not sure there is such a feature, I haven't added any features to the mod and just updated it as-is

I don't know which ones lxly9 is using, but I have a lot of mods, full list here:
https://pastebin.com/gLY2dx5D

@retrixe
Copy link
Author

retrixe commented Dec 19, 2023

These are a lot of mods which unfortunately I can't sift through and test myself, I advise trying a binary search (remove half the mods and see if the bug persists) to narrow down any potential conflicts with other mods?

@BoardAnims
Copy link

In 1.20.1 Forge, the damage numbers display black, no matter if the color values are changed in the config files...

@Jszp03
Copy link

Jszp03 commented Jun 27, 2024

Can you add mobs to blacklist?

Cobblemon mobs is incompatible because all cobblemons have different health system, and it already includes healthbars for them so it overlaps

@ditt0132
Copy link

what about 1.21? someone have a progress? or i can try

@RealAprilF00lz
Copy link

this happened on a different unofficial updated torohealth mod too https://www.curseforge.com/minecraft/mc-mods/torohealth-unofficial

1.20.1-forge-1
when the hud of this mod activates, the name on the boss bar of certain bosses, like l_ender's cataclysm bosses and the luxtructosaurus from alex's caves, will move to another part of the screen, leaving only its shadow on the boss bar. if there is more than one boss bar, this only happens if that boss bar is below every other boss bar

@kkellogg378
Copy link

Any updates for 1.21.1 fabric?

@tangjin0418
Copy link

tangjin0418 commented Nov 3, 2024

@kkellogg378
torohealth-1.21.1.zip
Try this.

Sorry the community, no source code (I deleted it because I originally just made for personal use)

@kkellogg378
Copy link

@kkellogg378 torohealth-1.21.1.zip Try this.

Sorry the community, no source code (I deleted it because I originally just made for personal use)

This ended up having some odd graphical issues - the bars wouldn't be anywhere near their respective mobs.

I did notice there was a fork that works really well though: healthbars

@retrixe
Copy link
Author

retrixe commented Nov 9, 2024

Can you add mobs to blacklist?

Cobblemon mobs is incompatible because all cobblemons have different health system, and it already includes healthbars for them so it overlaps

I've been busy with college for the greater part of a year, I'm looking into 1.20.5/6, 1.21.0/1 and 1.21.2/3 updates now

Let me know if you're still interested for me to look into adding this feature

@retrixe retrixe force-pushed the feat/1.19.3-support branch 3 times, most recently from ddac72d to 7203bb6 Compare December 5, 2024 09:59
- Fix F3 debug HUD detection.
- Handle new split textures correctly.
- Update Gradle, Loom, FLoader/FAPI, Yarn.
- Use FAPI's WorldRenderEvents instead of custom mixin (we already depend on FAPI).
- Adapt to minor API changes.
- Require Java 21 as the baseline.
- Update Gradle, Loom, FLoader/FAPI, Yarn.
- Adapt to minor API changes.
- Update Gradle, Loom, FLoader/FAPI, Yarn.
@retrixe retrixe force-pushed the feat/1.19.3-support branch from 7203bb6 to b3e8a04 Compare December 5, 2024 10:08
@retrixe
Copy link
Author

retrixe commented Dec 5, 2024

Why are damage numbers black?

Released new versions for 1.20+ that fix this issue. I've updated the mod till 1.21.4, but due to some bugs, the 1.21.2+ release is delayed

I've edited the PR to note all currently known issues, let me know if I'm missing something

@retrixe
Copy link
Author

retrixe commented Dec 5, 2024

Update: I've found a fix for damage particles not appearing when using Iris shaders too on 1.20.5+ (unfortunately the fix doesn't work on 1.20-1.20.4) 🎉 I'm currently republishing the versions onwards as a result

With this fix this PR is now bug-free

@retrixe retrixe force-pushed the feat/1.19.3-support branch 3 times, most recently from 5621a28 to b3e8a04 Compare December 5, 2024 13:31
- Adapt to minor API changes.
- Update Gradle, Loom, FLoader/FAPI, Yarn.
@retrixe retrixe force-pushed the feat/1.19.3-support branch from b3e8a04 to b382984 Compare December 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.