Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide armorstand's healthbar #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CTAK-CO6AK
Copy link
Contributor

This patch allows to hide armorstand's healthbars.
Because why do you even want to hurt these little creatures that hold your armor?

@frodare
Copy link
Member

frodare commented Nov 7, 2020

LOL, I should have done this a long time ago.

I think we should remove the config and simply opt to never show armor stands.

@CTAK-CO6AK
Copy link
Contributor Author

I think we should remove the config and simply opt to never show armor stands.

I think we should add a config menu that shows all entities, and we can disable or enable some of them

@frodare
Copy link
Member

frodare commented Nov 7, 2020

For now I prefer to just filter out the armor stands with no config option to keep the config as simple and meaningful as possible. The mod is already filtering on only LivingEntity so that should get it pretty close. There is nothing stopping the addition of config options in the future if they turn out to be needed.

@CTAK-CO6AK
Copy link
Contributor Author

Understandable, but maybe someone wants to see armor stand's healthbar?
Maybe its useful on some custom servers?

@frodare
Copy link
Member

frodare commented Nov 7, 2020

This is the type of thing that once a couple people asked for that feature explaining the reasons they wanted it, I would add the config option in then. I consider having armor stands show up in this mod a bug, cause by Mojang having them extend LivingEntity for whatever reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants