Merge pull request #190 from Totodore/fix-async-handlers

Fix async handlers not run

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.7.3
+## socketioxide
+* Fix [#189](https://github.com/Totodore/socketioxide/issues/189). Async message handlers were never called because the returned future was not spawned with `tokio::spawn`.
+
 # 0.7.2
 ## socketioxide
 * The `on_disconnect` callback now takes a `SocketRef` rather than an `Arc<Socket>` to match other handlers. It also avoids that the user clone the socket and create a memory leak.

Cargo.toml

@@ -39,7 +39,7 @@ warp = "0.3.6"
 salvo = { version = "0.58.5", features = ["tower-compat"] }
 
 [workspace.package]
-version = "0.7.2"
+version = "0.7.3"
 edition = "2021"
 rust-version = "1.67.0"
 authors = ["Théodore Prévot <"]

e2e/socketioxide/socketioxide.rs

@@ -23,9 +23,10 @@ fn on_connect(socket: SocketRef, Data(data): Data<Value>) {
         },
     );
 
+    // keep this handler async to test async message handlers
     socket.on(
         "message-with-ack",
-        |Data::<Value>(data), ack: AckSender, Bin(bin)| {
+        |Data::<Value>(data), ack: AckSender, Bin(bin)| async move {
             info!("Received event: {:?} {:?}", data, bin);
             ack.bin(bin).send(data).ok();
         },

socketioxide/Cargo.toml

@@ -14,7 +14,7 @@ readme = "../README.md"
 
 
 [dependencies]
-engineioxide = { path = "../engineioxide", version = "0.7.2" }
+engineioxide = { path = "../engineioxide", version = "0.7.3" }
 futures.workspace = true
 tokio = { workspace = true, features = ["rt"] }
 serde.workspace = true

socketioxide/src/handler/message.rs

@@ -269,7 +269,8 @@ macro_rules! impl_async_handler {
                     },
                 };
 
-                (self.clone())($($ty,)* last);
+                let fut = (self.clone())($($ty,)* last);
+                tokio::spawn(fut);
             }
         }
     };