chore: migrate deposits into sd59x60 #9
Conversation
| feesDenominatedInPoolTokens[0] += restFee;//we give rest of the fee (if any) to the first recipient | ||
| } | ||
|
|
||
| function calculateRedemptionFee(address tco2, address pool, uint256 depositAmount) external override returns (address[] memory recipients, uint256[] memory feesDenominatedInPoolTokens) { | ||
| require(depositAmount > 0, "depositAmount must be > 0"); |
There was a problem hiding this comment.
Redemption amount must be > 0
There was a problem hiding this comment.
yea, but our interface has the param "depositAmount" so intentionally keep it like this
There was a problem hiding this comment.
yea, but our interface has the param "depositAmount" so intentionally keep it like this
should it though? maybe the interface should be changed then as well
| feesDenominatedInPoolTokens[i] = (totalFee * _shares[i]) / 100; | ||
| restFee -= feesDenominatedInPoolTokens[i]; | ||
| } | ||
|
|
||
| require(restFee >=0); | ||
| require(restFee >= 0); | ||
| recipients = _recipients; |
There was a problem hiding this comment.
is this ok that we assign a reference here to our field and expose it outside? or is it still copied over?
There was a problem hiding this comment.
It's copied but not via the manually copying each item, should be more efficient
| @@ -44,27 +34,30 @@ contract FeeCalculator is IDepositFeeCalculator, IRedemptionFeeCalculator { | |||
| } | |||
|
|
|||
| function calculateDepositFees(address tco2, address pool, uint256 depositAmount) external override returns (address[] memory recipients, uint256[] memory feesDenominatedInPoolTokens) { | |||
| require(depositAmount > 0, "depositAmount must be > 0"); | |||
There was a problem hiding this comment.
Deposit amount must be greater than 0 could be a better phrasing?
There was a problem hiding this comment.
depositAmount refers to param name
This simplifies the code by using sd59x60 for deposits.