Implement SSK Sword #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested.
dlee13
reviewed
Jun 29, 2024
src/main/java/xyz/holocons/mc/holoitemsrevamp/item/SSKSwordBook.java
Outdated
Show resolved
Hide resolved
dlee13
reviewed
Jun 29, 2024
No longer an e-book.
|
Just tested; the main functionality seems to work. Still need to test other stuff (recipes, setting damage to negative, etc) |
|
Tested the recipe. Negative damage is overhealing. Will ask about that more in discord. |
|
So you know, Bukkit#addRecipe already registers the flipped recipes. There's no reason to manually reverse them like Klin did. And you don't need to put comments about left/right recipes or recipe0 or whatever. And PaperAPI 1.21 has an actual heal api method. We just don't have it yet since the project is depending on 1.20.1 |
|
Oh, 1.21 has a heal api method? I might pull #29 into draft then just so it can use that, even if it only really changes one line of code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently untested; I'll test it another time. I'm making the PR now if you want to check the code, though.
Task list below.