fix: didn't expand logprs

Tractables · Dec 22, 2024 · d4f6143 · d4f6143
1 parent 892275d
commit d4f6143
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/qc/benchmarks/benchmarks.jl b/qc/benchmarks/benchmarks.jl
@@ -454,6 +454,7 @@ function produce_loss(rs::RunState, m::FeatureSpecEntropyLossMgr, epoch::Integer
                 if m.p.train_feature
                     [lpr_eq * empirical_feature_logpr, empirical_feature_logpr]
                 else
+                    lpr_eq = Dice.expand_logprs(l, lpr_eq)
                     [lpr_eq * compute(a, lpr_eq), empirical_feature_logpr]
                 end
             else
@@ -463,7 +464,8 @@ function produce_loss(rs::RunState, m::FeatureSpecEntropyLossMgr, epoch::Integer
         )
         push!(m.num_meeting, num_meeting / length(samples))
 
-        loss = Dice.expand_logprs(l, loss) / length(samples)
+        # loss = Dice.expand_logprs(l, loss) / length(samples)
+        loss = loss / length(samples)
         m.current_loss = loss
         m.current_actual_loss = actual_loss
         m.current_samples = samples