fix: add CorvusOS's build fingerprint for LG V50 (flashlmdd) #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an OR condition for the check on flashlmdd's build fingerprint to support CorvusOS's last official release build fingerprint (
lge/corvus_flashlmdd/flashlmdd:13/TD1A.221105.001/1668359496:user/release-keys
) in addition to the one from the stock firmware from LGE.Now, the (obvious) question:
Why would anyone do this?
See, the issue with using LG's stock vendor is that some functionality breaks under most if not all GSIs:
INFO
, notASSIST
using LG's stock vendor, causing it to not work on basically anythingimmvibed
, straight up does not work. That daemon appears to check for device build fingerprint, OEM and even the Android version before it would do anything with the vibration motor.By using Corvus as a base, GSIs benefits from:
cheetah
in its fingerprintgoogle/cheetah/cheetah:13/TD1A.221105.003/9229241:user/release-keys
, no good for identifying what the device.I'm fairly sure this may break a rule somewhere with overlays, but gonna attempt to PR this anyway, since it does improves the general experience for GSIs on these devices