Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix generated TPL IMPORTED targets with tribits:: (#548, #299) #549

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Prefix generated TPL IMPORTED targets with tribits:: (#548, #299) #549

merged 1 commit into from
Dec 12, 2022

Conversation

bartlettroscoe
Copy link
Member

rabartlett1972
rabartlett1972 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@rabartlett1972 rabartlett1972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go ahead and approve this so it can merge and set up a post-merge review

@bartlettroscoe
Prefix generated TPL IMPORTED targets with tribits:: (#548, #299)
527dca8 
This is to avoid clashes such as reported in:

* #548

like CUDA::cufft from FindCUDAToolkit.cmake and fmt::fmt from Findfmd.cmake.
@bartlettroscoe bartlettroscoe force-pushed the 548-prefix-imported-targets branch from be86a19 to 527dca8 Compare December 12, 2022 18:53
@bartlettroscoe bartlettroscoe merged commit 0dcb78d into master Dec 12, 2022
@bartlettroscoe
Copy link
Member Author

Hello @KyleFromKitware, can you please do a post-merge review when you have time?

This was referenced Dec 12, 2022
Closed
Closed
KyleFromKitware
KyleFromKitware reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@KyleFromKitware KyleFromKitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bartlettroscoe bartlettroscoe mentioned this pull request Dec 12, 2022
Closed
@bartlettroscoe bartlettroscoe mentioned this pull request Dec 20, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromKitware KyleFromKitware KyleFromKitware left review comments

@rabartlett1972 rabartlett1972 rabartlett1972 approved these changes

Assignees
No one assigned
Labels
component: core type: bug type: enhancement
Projects
TriBITS Refactor
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartlettroscoe @KyleFromKitware @rabartlett1972