-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing zones to enus #41
base: master
Are you sure you want to change the base?
Conversation
@Sarjuuk could you take a look at this ? |
Refering to Sarjuuk#227, this doesn't fix the real problem that the assigned zone is wrong. You just give a name to the wrong zone. you might argue future-proofing the js variables for custom Quest zoneOrSort but even then this PR only provides locales to the frontend |
well, what about https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=2918 ? is that wrong zone too ? or is it missing the zone name only ? |
those were instanced until wotlk, when they became part of the open world. (no idea why there are still NPCs spawned inside)
|
it sounds good if you want to close this PR, but please reopen Sarjuuk#227 . Let me know if there is something to do to fix it (I guess you have the same issue locally or ?) |
Include the zones retrieved with this query (which might not be correct but it adds a lot of zones):
Fixes Sarjuuk#227