Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist component #187

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

Sneha0019
Copy link
Contributor

@Sneha0019 Sneha0019 commented Jun 23, 2024

Description

A clear and concise description of what the PR does.

  • This PR does the following:
    -Adds the wishlist feature by integrating backend functionality.
    -Refactors the Shop page to include wishlist symbols.

Related Issues

Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.
-Added a new feature to our project for managing wishlists.
-Integrated backend endpoints for wishlist management.
-Updated the Shop page to display wishlist symbols.

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

WISHLIST_FEATURE_RESOLVED.mp4

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Sneha0019
Copy link
Contributor Author

Hello, @Trisha-tech I've implemented the wishlist functionality, which required integrating backend endpoints for adding, fetching, and removing products from the wishlist. Additionally, I've made corresponding frontend updates, including logic adjustments and changes to the shop page to incorporate wishlist symbols.

Given the complexity and effort involved in implementing this feature, I would greatly appreciate your feedback on the code and changes made.
Moreover, considering the challenges faced and the skills developed throughout this process, I respectfully request your consideration for an upgrade the label to Level 3 if you can. I believe this reflects the added responsibility and growth demonstrated in successfully completing this task.
Thank you for your time, guidance, and continuous support!

@Trisha-tech Trisha-tech merged commit 2a80504 into Trisha-tech:master Jun 25, 2024
2 checks passed
@Trisha-tech
Copy link
Owner

Description

A clear and concise description of what the PR does.

  • This PR does the following:
    -Adds the wishlist feature by integrating backend functionality.
    -Refactors the Shop page to include wishlist symbols.

Related Issues

Link any related issues using the format Fixes #issue_number. This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR. -Added a new feature to our project for managing wishlists. -Integrated backend endpoints for wishlist management. -Updated the Shop page to display wishlist symbols.

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

WISHLIST_FEATURE_RESOLVED.mp4

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

This is showing error
screenshot-localhost_3000-2024 06 25-12_32_31

@Sneha0019
Copy link
Contributor Author

Hey, @Trisha-tech that error was due to login/logout functionality logic was not properly define Let me show you

Here below token was stored in localStorage
image

and during logout you were removing token from session storage instead of localstorage
image

Then I made changes in logout logic by putting localStorage instead of sessionStorage
image

Also I made changes in navbar so when user is not logged in he/she will be redirected to login page
image

Now I have made required changes so no errors will be show! How should I make pull request to update changes in main repo..
Is it okay if I make a new issue. You can assign label of level1 there I can push all changes

Thank you!

@Sneha0019
Copy link
Contributor Author

@Trisha-tech , please reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wishlist frontend + Backend[Feature Request]:
2 participants