-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wishlist component #187
Wishlist component #187
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
Hello, @Trisha-tech I've implemented the wishlist functionality, which required integrating backend endpoints for adding, fetching, and removing products from the wishlist. Additionally, I've made corresponding frontend updates, including logic adjustments and changes to the shop page to incorporate wishlist symbols. Given the complexity and effort involved in implementing this feature, I would greatly appreciate your feedback on the code and changes made. |
|
Hey, @Trisha-tech that error was due to login/logout functionality logic was not properly define Let me show you Here below token was stored in localStorage and during logout you were removing token from session storage instead of localstorage Then I made changes in logout logic by putting localStorage instead of sessionStorage Also I made changes in navbar so when user is not logged in he/she will be redirected to login page Now I have made required changes so no errors will be show! How should I make pull request to update changes in main repo.. Thank you! |
@Trisha-tech , please reply! |
Description
A clear and concise description of what the PR does.
-Adds the wishlist feature by integrating backend functionality.
-Refactors the Shop page to include wishlist symbols.
Related Issues
Link any related issues using the format
Fixes #issue_number
.This helps to automatically close related issues when the PR is merged.
Changes
List the detailed changes made in this PR.
-Added a new feature to our project for managing wishlists.
-Integrated backend endpoints for wishlist management.
-Updated the Shop page to display wishlist symbols.
Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.
npm install
to install dependencies.npm test
to execute the test suite.Screenshots (if applicable)
WISHLIST_FEATURE_RESOLVED.mp4
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.