Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart Status update when user is not logged in #256 #264

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

Vishesh-Tripathi
Copy link
Contributor

Description

  • This PR does the following:
    • Adds ... i updated 2 pages cart.jsx and navbar.jsx
    • Fixes ...when user is not logged in and clicks on cart icon then it redirect him to login page
    • Updates ...

Related Issues

there was a problem with env sample JWT_SECRET was missing from there .

Changes

List the detailed changes made in this PR.

  • Fixed a bug in ... the cart section based on login status

Testing Instructions

i do not used any dependicies so testing instruction will be same

Online.Book.Sales.and.8.more.pages.-.Personal.-.Microsoft_.Edge.2024-10-02.12-37-46.online-video-cutter.com.mp4

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

github-actions bot commented Oct 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Trisha-tech
Copy link
Owner

Description

  • This PR does the following:

    • Adds ... i updated 2 pages cart.jsx and navbar.jsx
    • Fixes ...when user is not logged in and clicks on cart icon then it redirect him to login page
    • Updates ...

Related Issues

there was a problem with env sample JWT_SECRET was missing from there .

Changes

List the detailed changes made in this PR.

  • Fixed a bug in ... the cart section based on login status

Testing Instructions

i do not used any dependicies so testing instruction will be same

Online.Book.Sales.and.8.more.pages.-.Personal.-.Microsoft_.Edge.2024-10-02.12-37-46.online-video-cutter.com.mp4

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Kindly resolve these conflicts @Vishesh-Tripathi and add the issue no you are addressing.
Added forgot password feature by Mdraza78 · Pull Request #300 · Trisha-tech_OnlineBookSales - Google Chrome 10_5_2024 1_28_10 PM

@Vishesh-Tripathi
Copy link
Contributor Author

Issue no #256

@Trisha-tech Trisha-tech added bug Something isn't working level2 gssoc-ext labels Oct 5, 2024
@Trisha-tech Trisha-tech merged commit d63188f into Trisha-tech:master Oct 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants