Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhances With Best Code Practices, Code Style Guidelines And Acknowledgments #502

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

milansamuel609
Copy link
Contributor

@milansamuel609 milansamuel609 commented Oct 16, 2024

Description

Enhances the full documentation with best code practices, code style guidelines and acknowledgments

Related Issues

Link any related issues using the format Fixes #501 .
This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

  • Added Best Code Practices
  • Added Code Style Guidelines
  • Added Acknowledgments

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

image

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@milansamuel609
Copy link
Contributor Author

@Trisha-tech I have again re-requested the PR. Please kindly check once again. I have also raised issue for this. If you get any issue please message me. If its fine then please merge it and attach the gssoc extend label.

@Suman373 Suman373 added documentation Improvements or additions to documentation level1 gssoc-ext hacktoberfest-accepted For valid PRs during hacktoberfest event labels Oct 16, 2024
@Suman373 Suman373 requested a review from Trisha-tech October 16, 2024 14:22
@Suman373
Copy link
Collaborator

Good work !

@milansamuel609
Copy link
Contributor Author

Good work !

Thank you 🙂

@milansamuel609
Copy link
Contributor Author

@Trisha-tech could you please let me know how long it might take for the review to be completed ? I appreciate your assistance and look forward to your response.

@Trisha-tech Trisha-tech merged commit 6b0edcb into Trisha-tech:master Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation gssoc-ext hacktoberfest-accepted For valid PRs during hacktoberfest event level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation Update]: Added These Things Best Practices, Code Style Guidelines, and Acknowledgments
3 participants