Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Implemented Google Books API on search bar #562

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

amitroy-thedev
Copy link
Contributor

@amitroy-thedev amitroy-thedev commented Oct 19, 2024

Description

Implemented Google Books API on search bar

Related Issues

Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

  • Added a new feature to ...
  • Refactored the ...
  • Fixed a bug in ...

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

image
Screenshot 2024-10-19 233555

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

I've removed navbar searchbar as searching and listing books in navbar is not good ux

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@amitroy-thedev
Copy link
Contributor Author

Hey @Trisha-tech before any other conflict please merge this

@Trisha-tech Trisha-tech merged commit c014b1c into Trisha-tech:master Oct 22, 2024
2 checks passed
@Trisha-tech
Copy link
Owner

Description

Implemented Google Books API on search bar

Related Issues

Link any related issues using the format Fixes #issue_number. This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

  • Added a new feature to ...
  • Refactored the ...
  • Fixed a bug in ...

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

image Screenshot 2024-10-19 233555

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

I've removed navbar searchbar as searching and listing books in navbar is not good ux

Your Google Books API is not working. Kindly look into it. @amitroy-thedev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Implementation of Google Books API on search bar
3 participants