Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dark mode inconsistency issue throughout website #631

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

Sourabh782
Copy link
Contributor

@Sourabh782 Sourabh782 commented Oct 28, 2024

KINDLY MERGE #597 ( ALREADY REVIEWED ) BEFORE THIS PR AS THIS CONTAINS CHANGES MADE IN THAT PR ALSO.

Description

A clear and concise description of what the PR does.

  • This PR does the following:

    • Fixes : The dark mode inconsistency issue throughout the website

Related Issues

Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

  • Refactored the ... code to properly implement dark mode

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

some page changes:

  1. contact us:
    before:
    contact prev

    after:
    contact new

  2. terms and condition:
    before:
    terms prev

    after:
    term after

  3. privacy page:
    before:
    privacy prev

    after:
    privacy after

  4. other pages:

    Screenshot 2024-10-28 123626

    cancellation and return

    Screenshot 2024-10-28 123615

    license

    Screenshot 2024-10-28 130518

Additional Context

Any additional context or information that reviewers should be aware of.

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC
    !

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Sourabh782 Sourabh782 changed the title Dark Fixed dark mode inconsistency issue throughout website Oct 28, 2024
@Trisha-tech Trisha-tech added bug Something isn't working level2 gssoc-ext labels Oct 29, 2024
@Trisha-tech Trisha-tech merged commit ee442c3 into Trisha-tech:master Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DARK mode inconsistency throughout website
2 participants