Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 filters backend #101

Merged
merged 16 commits into from
Jun 4, 2024
Merged

V2 filters backend #101

merged 16 commits into from
Jun 4, 2024

Conversation

RamtinTJB
Copy link
Contributor

@RamtinTJB RamtinTJB commented May 22, 2024 •
edited by petabite
Loading

Tracking Info

Resolves #100
Resolves #70

Changes

  • Added new fields for the new filters in the frontend and backend
  • Integrated the v2 filters in the backend API
  • Refactored frontend code
  • Added FiltersConext

Testing

Manually verified the different combination of filters to make sure they display the right results

Note: I haven't figured out a way to implement the multi-option (checkbox) yet I'll add that pretty soon.

Confirmation of Change

image

@RamtinTJB RamtinTJB requested a review from soma-p May 22, 2024 00:31
@RamtinTJB RamtinTJB requested a review from petabite as a code owner May 22, 2024 00:31
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 5a12a36):

https://ushs-housing-portal-staging--pr101-v2-filters-backend-jve80v0m.web.app

(expires Tue, 11 Jun 2024 02:30:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7c2f834b767adfbe0b81630135daffa0bb77f003

petabite
petabite requested changes May 22, 2024
View reviewed changes
Copy link
Member

@petabite petabite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 🔥 💯 Left a couple comments below.

Also, do you think it's possible to implement the "$" and "sqft" prefix/postfix as in the designs?

image

backend/src/services/units.ts Outdated Show resolved Hide resolved
frontend/src/api/units.ts Outdated Show resolved Hide resolved
frontend/src/components/FilterPanel.tsx Outdated Show resolved Hide resolved
frontend/src/components/MinMaxFilter.tsx Show resolved Hide resolved
frontend/src/pages/Home.tsx Show resolved Hide resolved
petabite
petabite reviewed May 30, 2024
View reviewed changes
Copy link
Member

@petabite petabite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I just added some code to support persisting the filters when the user clicks "Back" on the unit details page. Should be good to go once you add the "Any" option for the "Housing Authority" filter!

@petabite petabite mentioned this pull request May 30, 2024
Merged
petabite
petabite approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@petabite petabite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !!

soma-p
soma-p approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@soma-p soma-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great!

@RamtinTJB RamtinTJB merged commit 2d3228d into main Jun 4, 2024
4 checks passed
@RamtinTJB RamtinTJB deleted the v2-filters-backend branch June 4, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soma-p soma-p soma-p approved these changes

@petabite petabite petabite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V2 Filters Backend Integration Advanced Unit Browsing - V2 Filters [ Epic 🏔️ ]
3 participants
@RamtinTJB @petabite @soma-p