return orderId on success response

Troopers · Sep 20, 2016 · def4b0c · def4b0c
1 parent f46b25f
commit def4b0c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/Controller/PaymentController.php b/Controller/PaymentController.php
@@ -193,22 +193,23 @@ public function paymentFinalizeSecureAction(Request $request, $orderId)
             $this->get('translator')->trans('appventus_mangopay.alert.pre_authorisation.success')
         );
 
-        return $this->redirect($this->get('appventus_mangopay.payment_helper')->generateSuccessUrl());
+        return $this->redirect($this->get('appventus_mangopay.payment_helper')->generateSuccessUrl($orderId));
     }
 
     /**
      * @param Request $request The request
+     * @param int $orderId
      *
      * This method shows the congratulations
      *
-     * @Route("/success", name="appventus_mangopaybundle_payment_success")
-     *
+     * @Route("/success/{orderId}", name="appventus_mangopaybundle_payment_success")
      * @return Response
      */
-    public function successAction(Request $request)
+    public function successAction(Request $request, $orderId)
     {
         return $this->render(
-            'AppVentusMangopayBundle::success.html.twig'
+            'AppVentusMangopayBundle::success.html.twig',
+            [ 'orderId' => $orderId ]
         );
     }
 }
diff --git a/Helper/PaymentHelper.php b/Helper/PaymentHelper.php
@@ -59,7 +59,7 @@ public function prepareCardRegistrationCallback(User $user, Order $order)
             )
         );
 
-        $successRedirect = $this->generateSuccessUrl();
+        $successRedirect = $this->generateSuccessUrl($order->getId());
 
         return array(
             'callback' => 'payAjaxOrRedirect("'
@@ -195,8 +195,9 @@ public function cancelPreAuthForOrder(Order $order, CardPreAuthorisation $preAut
         }
     }
 
-    public function generateSuccessUrl()
+    public function generateSuccessUrl($orderId)
     {
-        return $this->router->generate('appventus_mangopaybundle_payment_success');
+        return $this->router->generate('appventus_mangopaybundle_payment_success', ['orderId' => $orderId]);
     }
+
 }