Correct rendering of falsy values

TroyAlford · Mar 22, 2019 · 9dc6982 · 9dc6982
1 parent 47f7628
commit 9dc6982
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/source/components/JsxParser.js b/source/components/JsxParser.js
@@ -47,7 +47,7 @@ export default class JsxParser extends Component {
       case 'JSXElement':
         return this.parseElement(expression)
       case 'JSXText':
-        return (expression.value || '')
+        return expression.value
       case 'JSXAttribute':
         if (expression.value === null) return true
         return this.parseExpression(expression.value)

diff --git a/source/components/JsxParser.test.js b/source/components/JsxParser.test.js
@@ -238,6 +238,11 @@ describe('JsxParser Component', () => {
       expect(console.error).toHaveBeenCalledTimes(1)
       expect(console.error.mock.calls[0][0]).toMatch(/unrecognized in this browser/)
     })
+    it('renders falsy expressions correctly', () => {
+      const jsx = '<b>{false}{undefined}{0}{null}{[]}</b>'
+      const wrapper = shallow(<JsxParser jsx={jsx} renderInWrapper={false} />)
+      expect(wrapper.html()).toBe('<b>0</b>')
+    })
     it('skips over DOCTYPE, html, head, and div if found', () => {
       const { rendered } = render(
         <JsxParser jsx={'<!DOCTYPE html><html><head></head><body><h1>Test</h1><p>Another Text</p></body></html>'} />