Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): do not bun-dle react/react-dom #294

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

TroyAlford
Copy link
Owner

@TroyAlford TroyAlford commented Oct 29, 2024

This pull request includes several important updates to the package.json file and enhancements to the JsxParser component in source/components/JsxParser.tsx. The changes improve dependency management, build configuration, and add detailed documentation for the JsxParser component's properties and methods.

Dependency and Build Configuration Updates:

  • Updated the basis dependency to a specific version from GitHub. (package.json)
  • Modified the build script to externalize react and react-dom dependencies. (package.json)

Enhancements to JsxParser Component:

  • Removed unused imports and added detailed documentation for the TProps type and various methods within the JsxParser class. (source/components/JsxParser.tsx) [1] [2] [3]
  • Added JSDoc comments to methods for parsing JSX strings, expressions, chain expressions, member expressions, element names, and rendering parsed content. (source/components/JsxParser.tsx) [1] [2] [3] [4] [5]- add a proper bun dependency on TroyAlford/basis

@TroyAlford TroyAlford merged commit afb9a75 into develop Oct 29, 2024
1 check passed
@TroyAlford TroyAlford deleted the task/do-not-bun-dle-react branch October 29, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant