PLUG-106: Show failure reason, add polling logic, refactor core payme…

…nt update logic and logging

Api/Transaction/Data/DataInterface.php

@@ -24,6 +24,7 @@ interface DataInterface extends ExtensibleDataInterface
     public const UUID = 'uuid';
     public const TOKEN = 'token';
     public const STATUS = 'status';
+    public const FAILURE_REASON = 'failure_reason';
     public const INVOICE_UUID = 'invoice_uuid';
     public const PAYMENT_URL = 'payment_url';
     public const IS_LOCKED = 'is_locked';
@@ -110,6 +111,21 @@ public function getStatus(): ?string;
      */
     public function setStatus(string $status): self;
 
+    /**
+     * Get failure reason.
+     *
+     * @return string|null
+     */
+    public function getFailureReason(): ?string;
+
+    /**
+     * Set failure reason.
+     *
+     * @param string $failureReason
+     * @return $this
+     */
+    public function setFailureReason(string $failureReason): self;
+
     /**
      * Return invoice_uuid.
      *

Controller/Adminhtml/Credentials/Check.php

@@ -24,28 +24,12 @@
  */
 class Check extends Action implements HttpPostActionInterface
 {
-
     private const PEM_UPLOAD_FILE = '/truelayer/temp/private_key.pem';
-    /**
-     * @var DirectoryList
-     */
-    private $directoryList;
-    /**
-     * @var ClientFactory
-     */
-    private $clientFactory;
-    /**
-     * @var Json
-     */
-    private $resultJson;
-    /**
-     * @var ConfigRepository
-     */
-    private $configProvider;
-    /**
-     * @var File
-     */
-    private $file;
+    private DirectoryList $directoryList;
+    private ClientFactory $clientFactory;
+    private Json $resultJson;
+    private ConfigRepository $configProvider;
+    private File $file;
 
     /**
      * Check constructor.

Controller/Adminhtml/Log/Stream.php

@@ -22,7 +22,6 @@
  */
 class Stream extends Action implements HttpPostActionInterface
 {
-
     /**
      * Error log file path pattern
      */
@@ -32,22 +31,10 @@ class Stream extends Action implements HttpPostActionInterface
      */
     public const MAX_LINES = 100;
 
-    /**
-     * @var JsonFactory
-     */
-    private $resultJsonFactory;
-    /**
-     * @var DirectoryList
-     */
-    private $dir;
-    /**
-     * @var File
-     */
-    private $file;
-    /**
-     * @var RequestInterface
-     */
-    private $request;
+    private JsonFactory $resultJsonFactory;
+    private DirectoryList $dir;
+    private File $file;
+    private RequestInterface $request;
 
     /**
      * Check constructor.

Controller/Checkout/BaseController.php

@@ -13,16 +13,13 @@
 
 abstract class BaseController implements HttpGetActionInterface
 {
-    /**
-     * @var Context
-     */
     protected Context $context;
 
     /**
      * @param Context $context
      */
     public function __construct(
-        Context $context,
+        Context $context
     ) {
         $this->context = $context;
     }