Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLUG-106] Change order placement flow and refactor #22

Merged
merged 22 commits into from
Jun 19, 2024
Merged

[PLUG-106] Change order placement flow and refactor #22

merged 22 commits into from
Jun 19, 2024

Conversation

lighe
Copy link
Collaborator

@lighe lighe commented Jun 14, 2024

Changes:

  • Orders are now created upfront, in a pending payment state
  • Better handles payment failures by cancelling orders
  • Improvements to refunds to better handle refund failures
  • Improved handling of error states
  • General refactoring with stronger typing and improved logging

lighe added 18 commits May 8, 2024 12:03
@lighe
PLUG-106: Refactor start
ae9e56a
@lighe
PLUG-106: Place orders upfront, refactor webhook and return
0a6d24b
@lighe
PLUG-106: Handle failed payments
e8e3f79
@lighe
PLUG-106: Fix issues with quote editing and order placing
aa8e223
@lighe
PLUG-106: Fix pending logic
6dbbc05
@lighe
PLUG-106: Refactor to use payment gateway commands
ce65f4f
@lighe
PLUG-106: Wip
9080d55
@lighe
PLUG-106: Improve handling of pending state
1776f84
@lighe
PLUG-106: Show failure reason, add polling logic, refactor core payme…
0c83e02 
…nt update logic and logging
@lighe
PLUG-106: Add support for refund failed webhook, refund transaction t…
22db05b 
…able, refactoring.
@lighe
PLUG-106: Improve logging
428ef65
@lighe
PLUG-106: Remove test line
0bf1c52
@lighe
PLUG-106: Fix refunds reference, handle missing shipping address, bet…
2bb7906 
…ter quote restoration, invalidate minicart cache, better polling.
@lighe
PLUG-106: Do not send order emails upfront; cleanup
30bfebd
@lighe
PLUG-106: Merge origin/main
02bc0d2
@lighe
PLUG-106: Deduplicate error messages; improve polling logic; restore …
750d493 
…quote in case of payment creation failure.
@lighe
PLUG-106: Add custom error type that is always deduplicated and inval…
33972e8 
…idates frontend cache
@lighe
PLUG-106: Fix status url
f5f3bbd
@swarmia Swarmia
Copy link

swarmia bot commented Jun 14, 2024

✅  Linked to Story PLUG-106 · [Magento] Order placement refactor

@lighe lighe marked this pull request as ready for review June 19, 2024 10:33
@lighe lighe requested review from a team as code owners June 19, 2024 10:33
stefandanaita
stefandanaita approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@stefandanaita stefandanaita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@lighe lighe merged commit 05d3ae7 into main Jun 19, 2024
10 checks passed
@lighe lighe deleted the feature/PLUG-106-commands branch June 19, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tl-ariel-reano tl-ariel-reano tl-ariel-reano approved these changes

@stefandanaita stefandanaita stefandanaita approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lighe @stefandanaita @tl-ariel-reano