Add missing steps to build process #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarb95
reviewed
Sep 30, 2017
| @@ -18,7 +18,7 @@ sudo apt-get install android-tools-adb android-tools-fastboot autoconf \ | |||
| libftdi-dev libglib2.0-dev libhidapi-dev libncurses5-dev \ | |||
| libpixman-1-dev libssl-dev libstdc++6:i386 libtool libz1:i386 make \ | |||
| mtools netcat python-crypto python-serial python-wand unzip uuid-dev \ | |||
| xdg-utils xterm xz-utils zlib1g-dev ccache | |||
| xdg-utils xterm xz-utils zlib1g-dev ccache repo gcc-aarch64-linux-gnu | |||
There was a problem hiding this comment.
You shouldn't need to install gcc-aarch64-linux-gnu. This should be created with make toolchains and then adding "<tc_folder>/toolchains/aarch64/bin" and "<tc_folder>/toolchains/aarch32/bin" to your path.
Edit: I have it on my machine, but I'm still unconvinced it is necessary.
acarb95
reviewed
Sep 30, 2017
| cd $HOME/trustedcapsules/code/optee_app/capsule_gen/src/ | ||
| ./make_all_capsules | ||
| ``` | ||
| TODO: make this part of the regular build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.