-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use staleWhileRevalidate in caching middleware #22511
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request updates the caching middleware by modifying the parameters passed to the cache control function. The change adds the Assessment against linked issues
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
9a8e9a4
to
bbcb289
Compare
@mike182uk can you please have a look :D |
Fixes #22131
Description
Passes
staleWhileRevalidate
to thecacheControl
as it was missing previously, causing the above issue.Checklist
yarn test:all
andyarn lint
)