Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependencies for GH Actions and Docker #1735

Closed

Conversation

UlisesGascon
Copy link
Contributor

@UlisesGascon UlisesGascon commented Aug 23, 2023

Main Changes

Pinned dependencies for GitHub actions and Docker (4a739cc & 043d901)

Important

This PR has mapped the current version in usage for each dependency and pinned it in the Dockerfile and GitHub Actions workflow files. This makes the build more reproducible (immutable dependencies) and stable and also makes it easier to track changes in the dependencies.

While upgrading dependencies might seem complicated as it currently uses hashes, it is not. Because the dependencies can be upgraded automatically using dependabot #1734. Additionally, the dependencies include a human-readable version in the hash, so it is easy to know which version is being used:

steps:- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
FROM node:18.12.1@sha256:e9ad817b0d42b4d177a4bef8a0aff97c352468a008c3fdb2b4a82533425480df

Context

Related #1732

Changelog

@UlisesGascon UlisesGascon marked this pull request as ready for review August 23, 2023 00:14
@leblowl
Copy link
Collaborator

leblowl commented Sep 11, 2023

Thanks for this PR! Overall looks good to me, one nitpick: I am noticing this PR removes the newline at the end of each file, it's minor but does cause extra diffs

@holmesworcester
Copy link
Contributor

@UlisesGascon -- @EmiM just sent a note in Quiet wondering if you could resolve conflicts in this PR. Just wanted to note that here in case you weren't getting Quiet notifications, which are still pretty noisy ironically :)

@UlisesGascon
Copy link
Contributor Author

Conflict solved in d07df2f 🎉

@leblowl
Copy link
Collaborator

leblowl commented Oct 4, 2023

@UlisesGascon Sorry this is taking so long, if we resolve these conflicts we can merge this right away. I can also resolve conflicts if that's helpful.

@leblowl
Copy link
Collaborator

leblowl commented Mar 8, 2024

I fixed up the conflicts over here: #2340

@leblowl leblowl closed this Mar 8, 2024
@UlisesGascon UlisesGascon deleted the chore/pin-dependencies branch March 10, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants