feature/Users who request already-taken usernames should be invited to request a new username #1843

Kacper-RF · 2023-09-21T09:36:48Z

Pull Request Checklist

I have linked this PR to related GitHub issue.
I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

CHANGELOG.md

packages/state-manager/src/sagas/identity/identity.selectors.ts

packages/state-manager/src/sagas/identity/registerUsername/registerUsername.saga.test.ts

packages/backend/src/nest/storage/storage.service.ts

packages/backend/src/nest/registration/registration.service.ts

leblowl

Thanks for working on this @Kacper-RF, I have some initial thoughts and a little bit more left to review.

packages/backend/src/nest/connections-manager/connections-manager.service.ts

packages/backend/src/nest/registration/registration.service.ts

packages/backend/src/nest/registration/registration.functions.ts

packages/backend/src/nest/storage/storage.service.ts

packages/desktop/src/renderer/components/CreateUsername/CreateUsernameComponent.tsx

packages/mobile/src/components/Registration/UsernameRegistration.component.tsx

packages/state-manager/src/sagas/identity/identity.selectors.ts

…/1697

packages/backend/src/nest/connections-manager/connections-manager.service.ts

packages/backend/src/nest/registration/registration.service.ts

.../desktop/src/renderer/components/widgets/usernameTakenModal/UsernameTakenModal.container.tsx

packages/identity/src/common.ts

packages/state-manager/src/sagas/identity/registerUsername/registerUsername.saga.ts

…/1697

packages/identity/src/common.ts

packages/state-manager/src/sagas/socket/startConnection/startConnection.saga.ts

packages/backend/src/nest/registration/registration.functions.ts

Kacper-RF and others added 7 commits September 20, 2023 13:10

desktop - container, stories, test

90e3c83

adjust component

1c76661

Remove obsolete registrar code

26032b6

Unify registration function for owner and user

0ec4d44

Clean up registrar methods logic

4bbe2cf

mobile - screens, component, tests

c4ba087

add changelog

e40c4d5

Kacper-RF marked this pull request as ready for review September 21, 2023 12:11

organize code

df94c25

EmiM reviewed Sep 21, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

vinkabuki and others added 12 commits September 21, 2023 15:34

Remove test

3a80426

Update changelog

36d58a1

skip randomly failing websockets tests

2e8aec1

connection with state manager

0425139

next steps for pub and priv key

884634a

map old messages to new nickname

762919e

use dictionary with counter for usernames

799ba21

changelog

bb71d69

Add logic for graceful certificates and csrs handling in registrar

7ee91db

Remove inadequate registrar tests

f3ae4db

state manager tests

7b6f862

changelog

309f6bd

leblowl reviewed Sep 27, 2023

View reviewed changes

packages/state-manager/src/sagas/identity/identity.selectors.ts Outdated Show resolved Hide resolved

Kacper-RF and others added 7 commits September 27, 2023 12:27

fix in selector, error handling when using taken nickname

3b96e40

check only registered users

61a9437

Clean code and tests

ee4fae8

merge

9ce135e

desktop test and linter

c91d0fc

add test case for registerCertificate saga

781a2bb

show username taken screen on mobile, error handling on mobile

b1d2f6b

Kacper-RF and others added 4 commits September 28, 2023 11:52

fix mobile saga test

bf46d04

Add tests for extracting pending csrs

ef746a0

merge

3332578

registerUsername saga test for case with username taken

c0b42f9

Kacper-RF mentioned this pull request Sep 28, 2023

Users who request already-taken usernames should be invited to request a new username #1697

Closed

EmiM reviewed Sep 28, 2023

View reviewed changes

packages/state-manager/src/sagas/identity/registerUsername/registerUsername.saga.test.ts Outdated Show resolved Hide resolved

packages/backend/src/nest/storage/storage.service.ts Show resolved Hide resolved

packages/backend/src/nest/registration/registration.service.ts Show resolved Hide resolved

leblowl suggested changes Sep 29, 2023

View reviewed changes

Kacper-RF and others added 3 commits September 29, 2023 09:41

cr fixes, fix updateCertificate saga

1fca2fe

Improve code quality after code review

5375941

Merge branch 'feature/1697' of github.com:TryQuiet/quiet into feature…

e019b86

…/1697

leblowl suggested changes Oct 2, 2023

View reviewed changes

This was referenced Oct 3, 2023

Add certificatesRequests store validation #1893

Closed

Add certificates store validation #1899

Closed

Kacper-RF and others added 6 commits October 4, 2023 09:07

cr fixes

b3ac445

merge develop

be32eb0

Merge branch 'feature/1697' of github.com:TryQuiet/quiet into feature…

e6f7c42

…/1697

cleanup

eb28569

cleanup

5617d5e

fix PR comments

d60f9da

leblowl suggested changes Oct 5, 2023

View reviewed changes

packages/identity/src/common.ts Outdated Show resolved Hide resolved

packages/state-manager/src/sagas/socket/startConnection/startConnection.saga.ts Show resolved Hide resolved

vinkabuki and others added 3 commits October 5, 2023 08:37

PR comments

7240e51

Merged develop to feature/1697

525ea8b

update snapshots

203ede1

leblowl suggested changes Oct 5, 2023

View reviewed changes

packages/backend/src/nest/registration/registration.functions.ts Show resolved Hide resolved

fix extractPendingCsrs method flaws

9702f94

leblowl approved these changes Oct 9, 2023

View reviewed changes

Kacper-RF merged commit d3f835b into develop Oct 9, 2023
28 of 29 checks passed

siepra deleted the feature/1697 branch December 8, 2023 12:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/Users who request already-taken usernames should be invited to request a new username #1843

feature/Users who request already-taken usernames should be invited to request a new username #1843

Kacper-RF commented Sep 21, 2023 •

edited

Loading

leblowl left a comment

feature/Users who request already-taken usernames should be invited to request a new username #1843

feature/Users who request already-taken usernames should be invited to request a new username #1843

Conversation

Kacper-RF commented Sep 21, 2023 • edited Loading

Pull Request Checklist

leblowl left a comment

Choose a reason for hiding this comment

Kacper-RF commented Sep 21, 2023 •

edited

Loading